Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renameat and unlinkat are commented out. #88

Open
andrewchambers opened this issue Jun 2, 2022 · 2 comments
Open

renameat and unlinkat are commented out. #88

andrewchambers opened this issue Jun 2, 2022 · 2 comments

Comments

@andrewchambers
Copy link

andrewchambers commented Jun 2, 2022

It seems like these calls were disabled for some reason (perhaps to support old kernels). They might be worth adding again?

I do wonder what benefit they provided compared to walk and remove - it seems slightly unusual to include '/' in names when the original operations did not.

@garlick
Copy link
Member

garlick commented Jun 2, 2022

This was added by cb01cd2 as a stub - the actual diod_* operations were not written. It was added to the linux kernel by torvalds/linux@9e8fb38 and torvalds/linux@48e370f. I assume I must have been following along with the kernel development but decided it was not a priority?

Sorry, not remembering the history here! But anyway, adding it would not be quite as simple as un-commenting the code.

@andrewchambers
Copy link
Author

Thanks, makes sense. I see the implementations are not there yet either. No worries, I understand this project has been on the back burner for a while :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants