Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: utcfromtimestamp is deprecated in python 3.12. #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdsre
Copy link

@cdsre cdsre commented Mar 4, 2024

This commit switched to use fromtimestamp and pass in a timezone so the datetime is tz aware. In order to keep inline with the existing code I have updated the fromts which held reference to the utcfromtimestamp function to now hold a functool.parital function which will insert the tz on any function calls to fromts

fixes #45

…tched to use fromtimestamp and pass in a timezone so the datetime is tz aware. In order to keep inline with the existing code I have updated the fromts which held reference to the utcfromtimestamp function to now hold a functool.parital function which will insert the tz on any function calls to fromts

Signed-off-by: Chris Doyle <uk.chris.doyle+cdsre@gmail.com>
Copy link
Contributor

@Lawouach Lawouach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utcfromtimestamp is deprecated in Python 3.12
2 participants