Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avro output type & Kafka integration #33

Closed
wants to merge 6 commits into from

Conversation

tillson
Copy link

@tillson tillson commented Apr 3, 2020

No description provided.

@chazlever
Copy link
Owner

It looks like output format and output stream are very strongly tied together. Specifically, the command line interface has global configuration options for output-type (i.e., stdout, kafka) and format(i.e, json, avro). Sending JSON to Kafka should be a valid output configuration, but this is not supported in the current code. Output types should be generic regardless of the format. For example, in addition to stdout and Kafka, I could envision a file as another output type.

@chazlever chazlever linked an issue Apr 4, 2020 that may be closed by this pull request
@chazlever chazlever self-requested a review April 4, 2020 04:57
@chazlever chazlever added enhancement Accepted new features or enhancements feature-request Feature requests under consideration labels Apr 4, 2020
@tillson
Copy link
Author

tillson commented Apr 23, 2020

Alrighty, I've made those changes. JSON/avro are interchangable for all output types, and output types now include file.
Maybe in the future we can abstract the output streams into io.Writer so that we don't have to explicitly handle every combination of types/destinations.

I closed this for now as I need to test it a little more.

@tillson tillson closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Accepted new features or enhancements feature-request Feature requests under consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow output to be pointed somewhere other than a file/stdout
2 participants