Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Strided@2? #39

Closed
mcabbott opened this issue Mar 18, 2024 · 0 comments
Closed

Allow Strided@2? #39

mcabbott opened this issue Mar 18, 2024 · 0 comments

Comments

@mcabbott
Copy link

I haven't tried to use this package, but it is loaded by MLDataSets, and loads Strided.jl at v1, which holds back other things. Can it allow Strided v2?

Locally tests fail, so I did not try out the change:

[ Info: protocal 4
[ Info: Test NP
load: Error During Test at /Users/me/.julia/packages/Pickle/hQSk8/test/test_np.jl:16
  Test threw exception
  Expression: jlscalars[1] == tryparse(UInt32, pyconvert(Any, (npscalars[1]).__repr__()))
  type UInt32 has no field __repr__

Xref Jutho/Strided.jl#25 maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants