From f31adf47f257b89501b60373d507b09d5fdbaa26 Mon Sep 17 00:00:00 2001
From: Taha Abdelmoutaleb Cherfia <taha.cherfia@holi.team>
Date: Sat, 4 Nov 2023 15:32:21 +0100
Subject: [PATCH] feat(chromium): simplify EmulatedMediaType

---
 src/chromium/converters/html.converter.ts     | 6 ++++--
 src/chromium/converters/markdown.converter.ts | 6 ++++--
 src/chromium/converters/url.converter.ts      | 6 ++++--
 src/chromium/interfaces/converter.types.ts    | 2 ++
 src/common/constants.ts                       | 5 -----
 5 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/src/chromium/converters/html.converter.ts b/src/chromium/converters/html.converter.ts
index 0633da21..5b00219c 100644
--- a/src/chromium/converters/html.converter.ts
+++ b/src/chromium/converters/html.converter.ts
@@ -4,11 +4,13 @@ import FormData from "form-data";
 
 import { GotenbergUtils, PdfFormat } from "../../common";
 import { IConverter } from "../interfaces/converter.interface";
-import { PageProperties } from "../interfaces/converter.types";
+import {
+  EmulatedMediaType,
+  PageProperties,
+} from "../interfaces/converter.types";
 import { ConverterUtils } from "../utils/converter.utils";
 import { Converter } from "./converter";
 import { ChromiumRoute } from "../../main.config";
-import { EmulatedMediaType } from "../../common/constants";
 
 export class HtmlConverter extends Converter implements IConverter {
   constructor() {
diff --git a/src/chromium/converters/markdown.converter.ts b/src/chromium/converters/markdown.converter.ts
index 36f34f85..6549e8ef 100644
--- a/src/chromium/converters/markdown.converter.ts
+++ b/src/chromium/converters/markdown.converter.ts
@@ -4,11 +4,13 @@ import FormData from "form-data";
 
 import { GotenbergUtils, PdfFormat } from "../../common";
 import { IConverter } from "../interfaces/converter.interface";
-import { PageProperties } from "../interfaces/converter.types";
+import {
+  EmulatedMediaType,
+  PageProperties,
+} from "../interfaces/converter.types";
 import { ConverterUtils } from "../utils/converter.utils";
 import { Converter } from "./converter";
 import { ChromiumRoute } from "../../main.config";
-import { EmulatedMediaType } from "../../common/constants";
 
 export class MarkdownConverter extends Converter implements IConverter {
   constructor() {
diff --git a/src/chromium/converters/url.converter.ts b/src/chromium/converters/url.converter.ts
index 79b1b5c6..cc833d3f 100644
--- a/src/chromium/converters/url.converter.ts
+++ b/src/chromium/converters/url.converter.ts
@@ -1,4 +1,3 @@
-import { EmulatedMediaType } from "./../../common/constants";
 import { PathLike, constants, createReadStream, promises } from "fs";
 
 import { URL } from "url";
@@ -7,7 +6,10 @@ import FormData from "form-data";
 
 import { GotenbergUtils, PdfFormat } from "../../common";
 import { IConverter } from "../interfaces/converter.interface";
-import { PageProperties } from "../interfaces/converter.types";
+import {
+  EmulatedMediaType,
+  PageProperties,
+} from "../interfaces/converter.types";
 import { ConverterUtils } from "../utils/converter.utils";
 import { Converter } from "./converter";
 import { ChromiumRoute } from "../../main.config";
diff --git a/src/chromium/interfaces/converter.types.ts b/src/chromium/interfaces/converter.types.ts
index d5cf104d..f988bd35 100644
--- a/src/chromium/interfaces/converter.types.ts
+++ b/src/chromium/interfaces/converter.types.ts
@@ -19,3 +19,5 @@ export type PageProperties = {
   scale?: number; // The scale of the page rendering (default 1.0)
   nativePageRanges?: { from: number; to: number }; // Page ranges to print
 };
+
+export type EmulatedMediaType = "screen" | "print";
diff --git a/src/common/constants.ts b/src/common/constants.ts
index ed1bd762..2e3ef81d 100644
--- a/src/common/constants.ts
+++ b/src/common/constants.ts
@@ -3,8 +3,3 @@ export enum PdfFormat {
   A_2b = "PDF/A-2b",
   A_3b = "PDF/A-3b",
 }
-
-export enum EmulatedMediaType {
-  SCREEN = "screen",
-  PRINT = "print",
-}