Skip to content

Commit b57d170

Browse files
committed
:octocat:
1 parent 3252ea6 commit b57d170

File tree

2 files changed

+23
-12
lines changed

2 files changed

+23
-12
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
<!-- You can erase any parts of this template not applicable to your Pull Request. -->
2-
31
## Proposed changes
42

53
<!-- Describe your changes here to communicate to the maintainers why you'd like to include this pull request.
64
If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
75

86

7+
<!-- You can erase any of the parts below that are not applicable to your Pull Request. -->
8+
99
## Types of changes
1010

1111
<!-- Put an `x` in the boxes that apply -->
@@ -15,6 +15,8 @@ What types of changes does your code introduce?
1515
- [ ] Bugfix (non-breaking change which fixes an issue)
1616
- [ ] New feature (non-breaking change which adds functionality)
1717
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
18+
- [ ] Documentation fix or enhancement (no code was touched)
19+
- [ ] Other (CI, dependencies, etc., please describe)
1820

1921

2022
## Checklist:
@@ -23,7 +25,7 @@ What types of changes does your code introduce?
2325
- [ ] I have added tests that prove my fix is effective or that my feature works
2426
- [ ] I have added necessary documentation (if appropriate)
2527
- [ ] Any dependent changes have been merged and published in downstream modules
26-
- [ ] Lint and unit tests pass locally with my changes
28+
- [ ] Static analysis and unit tests pass locally with my changes
2729

2830

2931
## Further comments

.github/workflows/ci.yml

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# https://help.github.com/en/categories/automating-your-workflow-with-github-actions
2-
# https://github.com/sebastianbergmann/phpunit/blob/master/.github/workflows/ci.yml
1+
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions
2+
# https://github.com/sebastianbergmann/phpunit/blob/main/.github/workflows/ci.yaml
33

44
on:
55
push:
@@ -11,6 +11,10 @@ on:
1111

1212
name: "Continuous Integration"
1313

14+
env:
15+
PHP_EXTENSIONS: ast, fileinfo, gd, imagick, json, mbstring
16+
PHP_INI_VALUES: memory_limit=-1, error_reporting=-1, display_errors=On
17+
1418
jobs:
1519

1620
static-code-analysis:
@@ -36,11 +40,12 @@ jobs:
3640
uses: shivammathur/setup-php@v2
3741
with:
3842
php-version: ${{ matrix.php-version }}
43+
extensions: ${{ env.PHP_EXTENSIONS }}
44+
ini-values: ${{ env.PHP_INI_VALUES }}
3945
coverage: none
4046
tools: pecl
41-
extensions: ast, fileinfo, gd, imagick, json, mbstring
4247

43-
- name: "Update dependencies with composer"
48+
- name: "Install dependencies with composer"
4449
uses: ramsey/composer-install@v3
4550

4651
- name: "Run phan"
@@ -70,14 +75,15 @@ jobs:
7075
uses: shivammathur/setup-php@v2
7176
with:
7277
php-version: ${{ matrix.php-version }}
78+
extensions: ${{ env.PHP_EXTENSIONS }}
79+
ini-values: ${{ env.PHP_INI_VALUES }}
7380
coverage: pcov
7481
tools: pecl
75-
extensions: fileinfo, gd, imagick, json, mbstring
7682

7783
- name: "Install dependencies with composer"
7884
uses: ramsey/composer-install@v3
7985

80-
- name: "Run tests with phpunit"
86+
- name: "Run tests with PHPUnit"
8187
run: php vendor/bin/phpunit --colors=always --configuration=phpunit.xml.dist
8288

8389
- name: "Send code coverage report to Codecov.io"
@@ -105,10 +111,11 @@ jobs:
105111
- name: "Install PHP"
106112
uses: shivammathur/setup-php@v2
107113
with:
108-
php-version: "8.2"
114+
php-version: "8.3"
115+
extensions: ${{ env.PHP_EXTENSIONS }}
116+
ini-values: ${{ env.PHP_INI_VALUES }}
109117
coverage: none
110118
tools: phpDocumentor
111-
extensions: fileinfo, gd, imagick, json, mbstring
112119

113120
- name: "Build API docs"
114121
run: phpdoc --config=phpdoc.xml.dist
@@ -133,7 +140,9 @@ jobs:
133140
- name: "Install PHP"
134141
uses: shivammathur/setup-php@v2
135142
with:
136-
php-version: "8.2"
143+
php-version: "8.3"
144+
extensions: ${{ env.PHP_EXTENSIONS }}
145+
ini-values: ${{ env.PHP_INI_VALUES }}
137146
coverage: none
138147

139148
- name: "Install Sphinx"

0 commit comments

Comments
 (0)