Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deploying external agents with the machines watcher #2029

Open
8 of 10 tasks
ripienaar opened this issue Apr 10, 2023 · 3 comments
Open
8 of 10 tasks

Support deploying external agents with the machines watcher #2029

ripienaar opened this issue Apr 10, 2023 · 3 comments

Comments

@ripienaar
Copy link
Member

ripienaar commented Apr 10, 2023 •
edited
Loading

Later we'll rename it to plugins watcher once its properly generic.

  • New generic plugins watcher created, heavily machines watcher based so the basic mechanics are known. It's just been made generic
    • Various just renames for machines -> plugins
    • Target dir made configurable rather than assume machines dir - defaults to machines dir
    • Prefix of manager machines configurable from previous hardcoded mm_, this allows agent x and machine x to be managed correctly. Defaults to mm_
    • Machines manager auto agent plugin recreated on plugins
    • External Agents manager auto agent plugin created like machines manager
    • Integrated for testing into choria compose
  • Old mms command moved to choria machine plugins pack allowing us space to iterate there around things like validation etc
  • Old machines watcher kept - and not compiled in as before - for those relying on it
  • Docs updated for new plugins watcher not machines watcher
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 10, 2023
@ripienaar
(choria-io#2029) Allow target for machines manager to be set
37be7f4 
This essentially makes machines manager generic so it can manage anything
but we have a few other improvements to make, for example to allow a machine
and agent with the same name.

Also a few other random improvements

Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 10, 2023
@ripienaar
(choria-io#2029) Allow target for machines manager to be set
8bc18fa 
This essentially makes machines manager generic so it can manage anything
but we have a few other improvements to make, for example to allow a machine
and agent with the same name.

Also a few other random improvements

Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit that referenced this issue Apr 10, 2023
@ripienaar
Merge pull request #2030 from ripienaar/2029
634c2b6 
(#2029) Allow target for machines manager to be set
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 10, 2023
@ripienaar
(choria-io#2029) allow the name of generated agents to be customised
0367610 
This to avoid clashes between machines managers and agent managers

Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit that referenced this issue Apr 10, 2023
@ripienaar
Merge pull request #2031 from ripienaar/2029.1
62c0e7d 
(#2029) allow the name of generated agents to be customised
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 10, 2023
@ripienaar
(choria-io#2029) allow the name of generated agents to be customised
1786c44 
This to avoid clashes between machines managers and agent managers

Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit that referenced this issue Apr 10, 2023
@ripienaar
Merge pull request #2032 from ripienaar/2029.2
f66b515 
(#2029) allow the name of generated agents to be customised
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 11, 2023
@ripienaar
(choria-io#2029) Create plugins watcher
ccc2bf8 
This makes the machines watcher more generic and renames
it to plugins watcher, the standard build is updated to
include this instead of machines watcher.

For backward compatability the old machines watcher is
restored in the code base for later deprecation.

Command line was updated to use new watcher

Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 11, 2023
@ripienaar
(choria-io#2029) Create plugins watcher
6d57d4f 
This makes the machines watcher more generic and renames
it to plugins watcher, the standard build is updated to
include this instead of machines watcher.

For backward compatability the old machines watcher is
restored in the code base for later deprecation.

Command line was updated to use new watcher

Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit that referenced this issue Apr 11, 2023
@ripienaar
Merge pull request #2033 from ripienaar/2029.3
f41712e 
(#2029) Create plugins watcher
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 11, 2023
@ripienaar
(choria-io#2029) Extract some common code and reuse in CLI
dc6d840 
Also improve the plugins pack cli.

The external agents provider will check frequently at
first for new agents then settle into a 30s kind of interval,
with jitter.  This optimise bootup to deliver agents quickly
but with a more relaxed settled state

Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 11, 2023
@ripienaar
(choria-io#2029) Extract some common code and reuse in CLI
96a1f6e 
Also improve the plugins pack cli.

The external agents provider will check frequently at
first for new agents then settle into a 30s kind of interval,
with jitter.  This optimise bootup to deliver agents quickly
but with a more relaxed settled state

Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit that referenced this issue Apr 11, 2023
@ripienaar
Merge pull request #2034 from ripienaar/2029.4
e637de9 
(#2029) Extract some common code and reuse in CLI
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 11, 2023
@ripienaar
(choria-io#2029) ensure signatures are correctly verified in plugins …
5d87fe6 
…manager

Signed-off-by: R.I.Pienaar <rip@devco.net>
ploubser added a commit that referenced this issue Apr 11, 2023
@ploubser
Merge pull request #2035 from ripienaar/2029.5
ca9bd67 
(#2029) ensure signatures are correctly verified in plugins manager
@jeffmccune
Copy link
Contributor

You're probably aware, but just an FYI the choria machine mms command isn't plumbed to match the docs yet. I took a stab but wasn't sure if this should be part of the new plugin system. Only mention it in off chance it was overlooked.

@jeffmccune
Copy link
Contributor

Never-mind, I see it: choria machine plugins pack

@ripienaar
Copy link
Member Author

Yeah sorry about that been a bit of turbulence here as I realised it would be impossible to get the “machines” watcher to be more generic and keep working as before.

So there is a plugins watcher now that’s almost identical but can also handle rpc agents and more.

Docs not updated for that will try today.

Such is life on main I am afraid

ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 19, 2023
@ripienaar
(choria-io#2029) minor updates to plugin watcher
cde9d32 
Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit that referenced this issue Apr 19, 2023
@ripienaar
Merge pull request #2054 from ripienaar/2029
71b19c4 
(#2029) minor updates to plugin watcher
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 26, 2023
@ripienaar
(choria-io#2029) correct package name for pluginswatcher
dac882a 
Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit that referenced this issue Apr 26, 2023
@ripienaar
Merge pull request #2062 from ripienaar/2029.6
241417b 
(#2029) correct package name for pluginswatcher
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 26, 2023
@ripienaar
(choria-io#2029) avoid double based64 encode json.Marshal does on bytes
524a8b8 
Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit to ripienaar/go-choria that referenced this issue Apr 26, 2023
@ripienaar
(choria-io#2029) avoid double based64 encode json.Marshal does on bytes
ed3e07e 
Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar added a commit that referenced this issue Apr 26, 2023
@ripienaar
Merge pull request #2063 from ripienaar/2029.7
baae4a1 
(#2029) avoid double based64 encode json.Marshal does on bytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffmccune @ripienaar