Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel 7 support #4

Open
NeoPhi opened this issue Mar 28, 2018 · 2 comments
Open

babel 7 support #4

NeoPhi opened this issue Mar 28, 2018 · 2 comments

Comments

@NeoPhi
Copy link

NeoPhi commented Mar 28, 2018

Are there any plans to release a beta version of this plugin that works with babel 7?

@lostfictions
Copy link

For people landing here, it looks like @babel/transform-async-to-generator might let you do the same thing as this plugin?

https://babeljs.io/docs/en/next/v7-migration#babel-plugin-async-to-generator

{
  "plugins": [
-    ["@babel/transform-async-to-module-method"]
+    ["@babel/transform-async-to-generator", {
+      "module": "bluebird",
+      "method": "coroutine"
+    }]
  ]
}

@chpio
Copy link
Owner

chpio commented Aug 30, 2019

might let you do the same thing as this plugin?

No, it's not the same thing, my plugin checks if there's await-ing going on in the code, and switches to the more lightweight bluebird.method function. The problem here is the increased code-complexity for the checking and thus the effort of an update... i should maybe just mark it as deprecated in favor of the mentioned babel plugin.

edit: i should deprecated it in favor of the standard Promise impl, not bluebird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants