1.0-rc2 stable

[chrisgoringe]

rc2 is now stable on branch 1.0-rc2

Issues resolved

• scrollwheel now set to one step
• scrollwheel options: off, on, or require-shift
• step can be edited
• min/max/step edits can be applied to all similar nodes (same node type)
• textareas no longer show through the controller
• various minor graphical issues

Full list: https://github.com/chrisgoringe/cg-controller/milestone/22

[chrisgoringe]

I think I've resolved the issues with the sliders:

• step now saves
• the widget works for direct editing after slider parameter changes
• scroll works if you reduce step size below precision

[chrisgoringe]

Hey - a little bonus (which I'll revert if it breaks something) - I found a really easy way to allow the controller width to be changed...

[JorgeR81]

You're able to add new features so fast !

If it would only take 1 more day or 2, consider adding this last feature for 1.0

• [single column branch] dynamically hide scrollbar #138

It would look much better in the documentation images.
Especially with a narrow layout.

[chrisgoringe]

I've added it, but I'm a little nervous - testing required!

One known issue: if changing the width of the controller causes the height of a textarea to change (because of text wrapping), and this causes the content to overflow, the scrollbar doesn't appear. I think this is a pretty minor problem, and fixing it looks really high risk (due to differences between browser implementations of scrollbars...)

[JorgeR81]

if changing the width of the controller causes the height of a textarea to change

For me, the text box height stays the same. And a scrollbar it's added to the text box. It works very well !

[JorgeR81]

I've found an issue, but it's related to a previous problem.
 
I was toggling the advanced controls "on" and "off", to trigger the scrollbar.

It was working fine, but after toggling multiple times ( not a realistic use case ), the Controller started to increase width by itself. 
But I was able to grab the resize handle and fix it.

---

Also, I can't replicate this bug.
I just toggled the advanced controls, 50 times, to trigger the scrollbar, and it worked fine.

[JorgeR81]

I suggest for the Controller's default width to be the same as the "native" Sidebar.
For me it is 310 ( my monitor is 1920 x 1080 ).

I think it is the "sweet spot".
I feel like I have enough space, both in the Controller column, and in the graph canvas. 

[chrisgoringe]

I think it now is - #201

[chrisgoringe]

OK, so I've added a few more :)

198 Replace Advanced controls checkbox with icon

As a result of which, I also now allow the controller to be made even narrower.

138 Dynamically hide scrollbar

As discussed above

200 Show width while resizing controller

Please let me know if there are any showstoppers, or I merge this onto main and call it 1.0

[JorgeR81]

I noticed some visual issues, but they were "one off", and I was not able to replicate them.
#198 (comment)
#183 (reply in thread)

---

The only issue I keep having frequently, is this one:

• [ bug ] Controller changes size, after switching workflows. #199

I was having this issue before these features.
But now the issue is diferent.
The Controller increases size every time I switch workflows ( as I explain there in more detail )

[chrisgoringe]

now fixed I believe