1.5 branch

[chrisgoringe]

I'm creating a 1.5 branch. As before, please do not raise issues based on 1.5, it is work in progress.

Before even mentioning an issue here wait a few hours, update, and try again! I use the branch to test on two machines, so it will have code that I know is broken sometimes!

[chrisgoringe]

Done a couple of things on the branch

• Image batches [ Feature Request ] Support batch in Image Preview node #289
• Mask editor [ feature ] Open the MaskEditor from the Controller  #214 (ctrl-click for context menu)

[chrisgoringe]

see how it is now

[LukeG89]

Ok, now it's working! 🎉

But everytime I change image in Load Image with Subfolders node, I get this console error:

[chrisgoringe]

Ok, now it's working! 🎉

But everytime I change image in Load Image with Subfolders node, I get this console error

That's a custom node? Where does it come from? And was it previously working ok?

[LukeG89]

That's a custom node? Where does it come from? And was it previously working ok?

Yes, it's a modified version of Load Image node that can access subfolders inside input: comfyui-imagesubfolders
I don't remember getting these errors before

[LukeG89]

This same problem is present also with 🪛 Load image with metadata from ComfyUI-Crystools (I think he literally copied Load Image with Subfolders and added the metadata outputs)

[chrisgoringe]

Thanks! I knew it seemed too easy 😀

…

On Sun, 24 Nov 2024 at 7:49 PM, LukeG89 ***@***.***> wrote: Awesome! 🚀 But there are some bugs with the Mask Editor feature: - You can open more than 1 context menu - To close context menu, you have to click on canvas - After you edited an image, the image name on nodeblock is not updated (only the preview) and sometimes the window stop responding https://github.com/user-attachments/assets/8d9be609-526f-425f-8b55-ba57ed8e9f9d I had these two errors in Console: Uncaught TypeError: this.parent_nodeblock.show_image is not a function at Entry.wcm_manager_callback (panel_entry.js:126:35) at widget_change_manager.js:19:139 at Array.filter (<anonymous>) at WidgetChangeManager.notify (widget_change_manager.js:19:125) at Entry.target_widget.callback (panel_entry.js:106:37) at setWidgetValue (litegraph.es.js:4995:15) at callback (litegraph.es.js:4956:15) at HTMLDivElement.newCallback (menu_auto_nest.js:70:79) at HTMLDivElement.inner_onclick (litegraph.es.js:10757:37) This one everytime I select a different image: Uncaught TypeError: this.parent_nodeblock.show_image is not a function at Entry.wcm_manager_callback (panel_entry.js:126:35) at widget_change_manager.js:19:139 at Array.filter (<anonymous>) at WidgetChangeManager.notify (widget_change_manager.js:19:125) at Entry.target_widget.callback (panel_entry.js:106:37) at Entry.input_callback (panel_entry.js:140:46) — Reply to this email directly, view it on GitHub <#370 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMA6WXTUC2T5ZCATD5MT2CGHKRAVCNFSM6AAAAABSIFEU6SVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMZWGE3TQNI> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

[chrisgoringe]

Added support for the Trung switch. I think. I don't use this one, so I'm not certain, but see what you find.

Discovered that the value of the widget on the node doesn't update if you rename the slot while it is selected, so I've raised this as an issue over there.

Trung0246/ComfyUI-0246#46

[LukeG89]

There is a little bug with the highlight toggle button when you create and switch workflows

Highlight-Bug.mp4