Support for Power Lora from rgthree or similar

[yovsac]

sorry to post all these ideas, but the controller is very usefull for me. I use it as a menu to control my photoshop through a plugin. Having the posibility to integrate the loras would be a time saver.

[chrisgoringe]

Ideas are appreciated 😀

[yovsac]

Thank you!!

[chrisgoringe]

Power LoRA loader turns out to be rather difficult (it's in the system as #106).

However, the rgthree LoRALoaderStack works just fine. I know it lacks some of the features of (as isn't as cool as!) the power option, but maybe sufficient?

[LukeG89]

LoRA Loader Stack is deprecated by rgthree himself

[chrisgoringe]

Hmm. Power Lora loader is not very likely to get supported soon…

…

On Mon, 9 Dec 2024 at 9:00 pm, LukeG89 ***@***.***> wrote: LoRA Loader Stack is deprecated by rgthree himself image.png (view on web) <https://github.com/user-attachments/assets/d9b769dd-d9f3-4f70-ab78-aed9602a74bb> — Reply to this email directly, view it on GitHub <#421 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMA7CY36OTOOWDJHITDT2EVS2PAVCNFSM6AAAAABTHRDR2SVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNJQGYZDSNQ> . You are receiving this because you commented.Message ID: ***@***.*** com>

[LukeG89]

😭

[JorgeR81]

There is a way to have a similar capability in the Controller.

We can have the right click option to add a new lora node ( from: https://github.com/pythongosssss/ComfyUI-Custom-Scripts )
And the new node could be added automatically to the Controller.

The new node it's already wired, so we could do it all from the Controller.

[JorgeR81]

And we could also have an alternative solution for the Power Lora Loader.

In the branch, I see that the +Add Lora button is working correctly.

The problem are these complex ( "4 in 1" ) widgets, right ?

---

Can you get the widget information out of the Power Lora Loader ?
Then convert it to normal widgets ? ( see mockup )

This is still better that the old rgthree Lora Loader Stack node, because:

• We can disable loras, without losing the selected lora name ( very useful if you have many loras )
• We can add more than 4 loras, from the Controller, without adding more nodes.
• We can use clip and model weights, independently.

Don't forget that the Power Lora Loader also allows to use clip and model weights, independently.
And in this case we would probably need separate widgets, anyways.

This solution would also be useful, for compatibility reasons.
This way, users that already have the Power Lora Loader, don't have to make any changes to their workflows.

[chrisgoringe]

Yes, the button works on that branch, that’s easy. I’m very hesitant to go the route of “virtual nodes”, since it breaks the general model. I do have a basic version of the complex widgets working, but it lacks some of the functionality and I’m concerned that supporting this one node would take a lot of support effort

…

On Tue, 10 Dec 2024 at 3:04 am, JorgeR81 ***@***.***> wrote: And we could also have another solution, In the branch I see that the +Add Lora button is working correctly ? The problem are these complex ( "4 in 1" ) widgets, right ? p1.jpg (view on web) <https://github.com/user-attachments/assets/743dd8e0-16a0-46c2-80af-9f42bf61f695> ------------------------------ Can you get the widget information of the Power Lora Loader ? Then convert it to normal widgets and create "virtual" nodes for them ? We could bypass each "virtual" node ( so we don't need the toggle widgets ). The power loara loader also allows to clip and mode weights, separately, And in this case we would probably need separate widgets, anyways. This would also be useful, for compatibility reasons. This way, users that already have the Power Lora Loader, will not have to make any changes to their workflows. l3.png (view on web) <https://github.com/user-attachments/assets/3b97ea56-7233-415f-b329-9236bf39b846> — Reply to this email directly, view it on GitHub <#421 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMA3FVIAMJVNZ4RBR36T2EW5RNAVCNFSM6AAAAABTHRDR2SVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNJRGAZDMMY> . You are receiving this because you commented.Message ID: ***@***.*** com>

[JorgeR81]

I’m very hesitant to go the route of “virtual nodes”, since it breaks the
general model.

Yeah, I've already deleted the “virtual nodes” idea.
I have a new mockup, with individual, normal, widgets.
Check my updated post, when you're at the computer.

[JorgeR81]

I do have a basic version of the complex widgets working, but it lacks some
of the functionality

If you can have complex widgets it in Controller,

And by "lacking functionality", you mean the use of clip and model weights, independently, you could do it like this,

• With Single Strength we could have a triple widget ( COMBO + Boolean + slider ), like the node.

• With Separete Model & Clip we could have a double widget ( COMBO + Boolean ) and 2 simple sliders

---

But if this is too complex, I would still be happy with my last concept of always using 4 simple widgets per lora, in the Controller.

Here is that mockup again:

[chrisgoringe]

yeah, it's not so much that as the other features that the node supports - like setting the limits. Getting the built in limit editing to work consistently with the controller version of limit editing is not simple. It's not a UI issue - I've already implemented something not entirely unlike the above - but an internal logic issue...

[JorgeR81]

Getting the built in limit editing to work consistently with the controller version of limit editing is not simple

Does this node have its own limit edit system !?
Did you see that feature in the code ?

Because, I don't see it in the GUI. I don't think it's enabled.

[chrisgoringe]

Right click the widget on the node?

…

On Tue, 10 Dec 2024 at 10:51 am, JorgeR81 ***@***.***> wrote: Getting the built in limit editing to work consistently with the controller version of limit editing is not simple Does this node have its own limit edit system !? Did you see that feature in the code ? Because, I don't see it in the GUI. I don't think it's enabled. — Reply to this email directly, view it on GitHub <#421 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMA5O7ESPJV26RIKJLGD2EYUHBAVCNFSM6AAAAABTHRDR2SVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNJRGQZDANI> . You are receiving this because you commented.Message ID: ***@***.*** com>

[JorgeR81]

Right click the widget on the node?

I only see options to move the widget up or down, but that's just cosmetic.
That's the position of the widget in the node. 

[chrisgoringe]

"Show Info"

…

On Tue, 10 Dec 2024 at 10:58, JorgeR81 ***@***.***> wrote: Right click the widget on the node? I only see options to move the widget up or down, but that's just cosmetic. That's the position of the widget in the node. pl.jpg (view on web) <https://github.com/user-attachments/assets/8f0b6a72-20fe-4c17-9b7f-9be6bfb9ad50> — Reply to this email directly, view it on GitHub <#421 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMA57ZTQ4NTXOBV2FO6D2EYVEFAVCNFSM6AAAAABTHRDR2SVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNJRGQZDGMI> . You are receiving this because you commented.Message ID: ***@***.*** com>

[JorgeR81]

Ah OK ! That's an odd place to have such a setting.

I wonder how many users noticed that ?

Frankly, I would just override that.
And any other weird features it may have.
I don't think it would be a problem in terms of usability.

But if you don't think that's going to work, from a technical standpoint, then no worries :)

[chrisgoringe]

I’ll see what it looks like when I’m next at the code. If we’re comfortable ignoring that feature, it’s a lot more feasible…

…

On Tue, 10 Dec 2024 at 11:29 am, JorgeR81 ***@***.***> wrote: Ah OK ! That's an odd place to have such a setting. I wonder how many users noticed that ? Frankly, I would just override that. And any other weird features it may have. I don't think it would be a problem in terms of usability. But if you don't think that's going to work, from a technical standpoint, then no worries :) — Reply to this email directly, view it on GitHub <#421 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMA2QGN2XVGFSOHWWTK32EYYXLAVCNFSM6AAAAABTHRDR2SVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCNJRGQZTSMQ> . You are receiving this because you commented.Message ID: ***@***.*** com>

[JorgeR81]

By the way, this is not even a "hard" limit.

Apparently it just makes the font turn red, to inform you that you're out of the recommended values for that lora.

That's why this setting is in the "info" options. 
I think the developer just expects the user to insert the recommended values, from the lora creator, on civitai.
Sometimes the creators have these values in the lora description.  

[chrisgoringe]

OK, take a look on the power-lora-loader branch. Should be working for a single value (not separate values yet)

[JorgeR81]

And how do you change the lora name, once you've added it ?

I tried right click, and Ctrl+click, but is does not work.

[LukeG89]

If I manually insert the value for clip, then model will be changed insted.

Also if you drag the clip value to 0, that lora will switch to single strength.

I can confirm the bugs

Clip-Test.mp4

[LukeG89]

And how do you change the lora name, once you've added it ?

I tried right click, and Ctrl+click, but is does not work.

Apparently you can't change the lora after you added it

[JorgeR81]

Just a few more observations.
But these are more like feature requests, beyond the basic functionality:

• The lora name could be dimmed when it's toggled off, like in the node ( and the other boolean widgets, in the Controller ).

• It would be really cool if we could support the red font "limit" feature, somehow.
  Maybe changing the font, or even the slider color ?

• Right click option to change to "single strength" or separate values.

• Right click option to remove a lora from the Controller, like on the node.

---

[LukeG89]

And how do you change the lora name, once you've added it ?

I would add a way to popup the same "Choose a lora" menu like when you press "+ Add Lora" (as you can do in the node), so you can change the lora with another one.

Right click option to remove a lora from the Controller, like on the node.

Yes, this is an important feature to add

[chrisgoringe]

Note that this has now been merged onto 1.6 and the power-lora-loader bracnch deleted.

[yovsac]

Nice progress! On my side I only see a plus, not the loras and strength even after adding a lora, any ideas?

[LukeG89]

Sorry, we are on 1.6 branch!

[yovsac]

[LukeG89]

Have you update it? You can update with the manager

[yovsac]

Have you update it? You can update with the manager

Thank you, it works!!!