Sliders

[chrisgoringe]

Thoughts about sliders.

Really like the Blender style:

What to do about overriding the min/max/step, and making them be or not be sliders?

One suggestion:

Show sliders only on specific widgets, if all settings are filled.

For 2 reasons:

• the sliders that don't have a setting, will probably not work well anyways.
• I don't want a slider on some widgets ( eg. "height" and "width" ).

[chrisgoringe]

Thoughts:

(1) If we go with the blender style, you can always enter a value directly
(2) The current way of overrriding max min etc is pretty ugly

Assuming we go with the blender style, one option would be to be able to (say) shift-click a slider to bring up a dialog that allows you to edit the min, max, and rounding.

[JorgeR81]

Assuming we go with the blender style, one option would be to be able to (say) shift-click a slider to bring up a dialog that allows you to edit the min, max, and rounding.

Yes, I think this would be the best solution.

But, If I add settings to a Controller panel, would these be valid for other Controller panels ?

Now my settings work on multiple Controllers, in different workflows, as long as the node name is the same.

[JorgeR81]

I think it could work this way :

• The individual slider settings we add via this "shift-click menu" could go to a shared data table. 

• And the full table could be viewed ( and also edited ) in the settings. 

• The slider settings table could be similar to the new keybinds settings table, in the Frontend.

[chrisgoringe]

So my plan is:

Stage 1

Implement the Blender style sliders with the current override mechanism, and set all numeric types to use them. Since you can directly enter data in that style, this will be usable always, if not ideal.

Stage 2

Add the ability to edit the start/stop/round attributes of a slider (triple-click or shift-click, probably, popping up a dialog). This will be saved to a shared table, with options:

• just apply to this slider
• apply to all [cfg] sliders on [KSampler] nodes
• apply to all [cfg] sliders on any node

At this point the old mechanism will be retired (maybe auto converted, maybe not!)

Stage 3

Provide a mechanism to edit that shared table

[JorgeR81]

That sounds really good !

[chrisgoringe]

Step 1 done on the 0.8 branch - take a look @JorgeR81 :)

[chrisgoringe]

(Also did the image resizing)

[JorgeR81]

This works well.

But it has a small quirk.
If I double click to select the whole text, and then drag, it will also drag the text.

[JorgeR81]

Aesthetically, I think flat sliders would look better here.
And also matching the other widgets.

I've made a mockup:

---

original

---

Prompt box :

• remove border
• change color ( same as color as the node prompt box, in ComfyUI )

COMBO box :

• remove border
• change color ( same as color as the node prompt box, in ComfyUI )
• make COMBO box as tall as sliders

Sliders :

• flat look ( same color in all border sides )
• change border color ( same as color as the node prompt box, in ComfyUI )

[chrisgoringe]

#64

[JorgeR81]

Another nice visual improvement would be to hide the cursor, in the slider, while we are dragging.

[chrisgoringe]

#65

[chrisgoringe]

Merged 0.8 into main.

[chrisgoringe]

0.9 merged. Take a look.

[JorgeR81]

Nice !

---

One small improvement that could be made :

Once we clicked down, is it possible to keep dragging the slider if the mouse pointer leaves the slider area ?

Sometimes, I can't drag the slider all the way to the end ( e.g.: 0.98 ), and all the text is selected instead, because the mouse pointer leaves the slider area.

Since we already clicked down, to select the slider, dragging could still work even if we, accidently, leave the slider bar, and go into an adjacent slider. 
This would make the sliders more comfortable to use. 

[chrisgoringe]

Yeah, I had that, but there were some complications with the browser thinking other things were being dragged!

But I'll take another look, see if I can extend the active area a little somehow...

[JorgeR81]

Aesthetically, the GUI looks pretty good already !

I have some ideas for small improvements, but at this point it may just be my personal taste.

---

Original

---

New changes :

• Thicker slider value line ( that pale blue vertical line, it's thicker in the Blender sliders ).
• Same grey color in the title area, if no color is used ( like on the ComfyUI nodes )
• Align the sliders with the rest of the widgets, if possible. ( They've got a little longer ).

And some other stuff I mentioned before, if possible :

• Use the same color for the prompt box as used in Comfy UI
• Use that same color for the COMBO box
• Make COMBO box as tall as sliders
• Remove borders on widgets 

[chrisgoringe]

#71

[chrisgoringe]

OK, done a load of this stuff on branch 0.9.2.

Not merging yet, to see if errors arise, but feel free to play, it's fairly stable now (I think!)

[JorgeR81]

Minor issue:

If I click on slider the value, to type a value, but I don't change anything, then it will not go back to slider,
even if:

• I press enter
• I use other sliders
• I click on the canvas

To convert it back to a slider, I need to refresh the browser ( or hide and show the controller again ).

The users just double click by accident, or just change their mind, and want to cancel the typing.

[chrisgoringe]

#85

[JorgeR81]

Feature suggestion :

• Use the scroll wheel to change slider values ( on mouseover ).

This would be a good way to just increase / decrease, a single step or just a few steps, in sliders with a large range of values.
For instance, if I just want to increase the seed value, by 1, in the seed slider.

[chrisgoringe]

#86

[JorgeR81]

Minor issue:

The Controller is not updated when I change the node's color.
I need to refresh the browser ( or hide and show the controller again ).

[chrisgoringe]

Minor issue:

The Controller is not updated when I change the node's color.

I need to refresh the browser ( or hide and show the controller again ).

Yes, known issue. #82. Same if you change the title, or a few other things I've noted.

To fix these requires either hiking more closely into comfy code (which risks incompatibility issues), or a periodic check (which risks performance issues). Exploring best approach.

[JorgeR81]

Minor bug:

On a new workflow the Controller, the controller does not show up, when we use the right click menu to show it, for the first time.

Nothing happens when we click the button, and the menu does not go away.
The brower shows this error log:

We need to click again for the menu to go away.

And the, the next time we use the right click, it will work ( it will show the controller )

[chrisgoringe]

Please update, I think I pushed a fix for that

[JorgeR81]

I think this bug it's also on the latest update. 
I did git pull and git switch 0.9.2 about 1 hour ago.

Now I did an "update all" via Manager and it says all extensions are up to date.
And the issue is still there.

[JorgeR81]

Minor issue:

The KSampler preview does not seem to work anymore. It does not work at all now.

[chrisgoringe]

Added to #79

[JorgeR81]

I just noticed the KSampler image preview only works, when the Image Preview node is also added to the Controller !

I think this was the behavior even before this latest update.

So, I think nothing changed here.

[JorgeR81]

The previous minor bug ( on the first generation ) is still there, in this latest update.

But I think no new bug was introduced.