Bypass thoughts

[chrisgoringe]

Assuming group bypass gets implemented, and node bypassing doesn't:

• Should bypassed nodes be shown in the controller?
• If so, what visual indication should there be that they are bypassed?
• Should they be minimised by default (but openable)?
• If one node in a group is bypassed, then you bypass the group, then unbypass the group, should that node end up bypassed (as seems to make sense to my mind) or not (the Comfy behaviour)?

[JorgeR81]

In principle, I think the best way is to do whatever ComfyUI does, as closely as possible.
Even if it makes less sense to both of us, the average ComfyUI user will understand it better, because that's just how it works in ComfyUI.
But I would make an exception on the last one.

---

Should bypassed nodes be shown in the controller?

Yes, because they are shown in the graph canvas.

---

If so, what visual indication should there be that they are bypassed?

A bit of transparency and the bypass color. The same way Comfy UI does.
I personally, don't like that much. But every ComfyUI user knows what this color means.
And, by the way, users can now customize the bypass color : Comfy-Org/ComfyUI_frontend#993

---

Should they be minimised by default (but openable)?

They should be openable, like the nodes. 
Being bypassed and being collapsed should be different things, like on the nodes. 

---

If one node in a group is bypassed, then you bypass the group, then unbypass the group, should that node end up bypassed (as seems to make sense to my mind) or not (the Comfy behaviour)?

I personally hate this ComfyUI behavior.

For this to be fixed the user needs to use a switch or whatever.
And it will be hard to do for the average / new user.

If we can fix this in the Controller, we should do it !

[chrisgoringe]

Yes, I think I agree with all the above

[JorgeR81]

If you're not going to implement "individual node bypassing", give this feature ( #106 ) another look, later on ( maybe after 1.1 )

One of the main use cases for "individual node bypassing" is to apply / remove loras, with "one click".

But the Power Lora Loader (rgthree) node already has this feature integrated !

With the "true/false" widget support and the full width widgets, it could be easier to integrate in the Controller.

[chrisgoringe]

I've moved #106 into to 1.1 milestone (stuff in 1.1 is going to be allocated into the next few releases, it's just a holding spot!)