Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ feature ] Add Controller button to "go to group" #352

Closed
JorgeR81 opened this issue Nov 16, 2024 · 4 comments
Closed

[ feature ] Add Controller button to "go to group" #352

JorgeR81 opened this issue Nov 16, 2024 · 4 comments

Comments

@JorgeR81
Copy link

JorgeR81 commented Nov 16, 2024

EDIT: Following @LukeG89 sugestion, I think we should expand on the current Comfy UI features, instead ( #352 (comment) )


The Fast Groups Bypasser (rgthree) node, allows to bypass all groups in a workflow.
But it also has a button for centering the canvas in each one of these groups ( it's an arrow button, see the image below ).

We could have a similar button in each Controller's header.
This could be useful, because we don't need to add all the nodes to the Controller, and we can still easily access them in the graph.

Maybe also the arrow button:

ic1

We have free space for this in the header.
And if we change the collapsed header design ( #351 (comment) ) we could still use this feature with the collapsed headers !

h2


r1

@LukeG89
Copy link

LukeG89 commented Nov 16, 2024

And it would be even cooler if you can add the new "Fit View" animation! 😃

Fit_View_Animation.mp4

@JorgeR81
Copy link
Author

JorgeR81 commented Nov 16, 2024

And it would be even cooler if you can add the new "Fit View" animation! 😃

I didn't know about this. It works great !

Comfy-Org/ComfyUI_frontend#1474


Maybe we don't need a new button.

If possible, I think it would be better to integrate the Controller with this feature, instead of creating a new one.
It could even be used to "go to node", to check the wires.

  • With Fit View we can use the . keybind ( or a dedicated button ) to go to the selected group ( or node ).

For the Controller, it could work this way:

  • Mouseover a group button ( or node header ) in the Controller.
  • Use Ctrl+click to select that group ( or node ) in the graph, and enable Fit View to go there.
  • The Fit View position would be adjusted, to take in consideration the available canvas space, when Controllers are visible.

@LukeG89
Copy link

LukeG89 commented Nov 21, 2024

Now we can even use controllers as fast go-to-group buttons! So cool! 😎

Fit-View-Test.mp4

@JorgeR81
Copy link
Author

It's working very well !

Now we only need snapping for minimized controllers, so that we can minimize stacked columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants