Re-tweaked example (again)

This should take into consideration many forms

Author: softwarespot

application/controllers/api/Example.php

@@ -30,7 +30,7 @@ function __construct()
         $this->methods['user_delete']['limit'] = 50; // 50 requests per hour per user/key
     }
 
-    public function users_get($id = NULL)
+    public function users_get($id_param = NULL)
     {
         // Users from a data store e.g. database
         // $user = $this->some_model->getSomething($id);
@@ -40,8 +40,17 @@ public function users_get($id = NULL)
             3 => ['id' => 3, 'name' => 'Jane', 'email' => 'jane@example.com', 'fact' => 'Lives in the USA', ['hobbies' => ['guitar', 'cycling']]],
         ];
 
+        // Get the id parameter value
+        $id = $this->get('id');
+
+        // If NULL, then check the id passed as users/:id
+        if ($id === NULL)
+        {
+            $id = $id_param;
+        }
+
         // If the id parameter and query parameter don't exist, return all users instead
-        if ($id === NULL && $this->get('id') === NULL)
+        if ($id === NULL)
         {
             // Check if the users data store contains users (in case the database result returns NULL)
             if ($users)
@@ -60,16 +69,13 @@ public function users_get($id = NULL)
 
         }
 
-        // If the id has not been passed via the URL e.g. example/users/:id, then
-        // check the id query parameter id=? instead
-        if ($id === NULL || ctype_digit($id) === FALSE)
+        // Check if the id is a valid integer
+        if (ctype_digit($id))
         {
-            $id = $this->get('id');
+            // Cast as an int
+            $id = (int) $id;
         }
 
-        // Cast as an int
-        $id = (int) $id;
-
         // If not a valid id
         if ($id <= 0)
         {
@@ -107,17 +113,23 @@ public function users_post()
         $this->set_response($message, REST_Controller::HTTP_CREATED); // CREATED (201) being the HTTP response code
     }
 
-    public function users_delete()
+    public function users_delete($id_param = NULL)
     {
-        // If the id has not been passed via the URL e.g. example/users/:id, then
-        // check the id query parameter id=? instead
+        // Get the id parameter value
+        $id = $this->get('id');
+
+        // If NULL, then check the id passed as users/:id
         if ($id === NULL)
         {
-            $id = $this->get('id');
+            $id = $id_param;
         }
 
-        // Cast as an int
-        $id = (int) $id;
+        // Check if the id is a valid integer
+        if (ctype_digit($id))
+        {
+            // Cast as an int
+            $id = (int) $id;
+        }
 
         // If not a valid id
         if ($id <= 0)