Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't seem to get this working....(7 errors) #57

Open
Zachweiss10 opened this issue Feb 1, 2021 · 6 comments
Open

can't seem to get this working....(7 errors) #57

Zachweiss10 opened this issue Feb 1, 2021 · 6 comments

Comments

@Zachweiss10
Copy link

  1. TypeError: Cannot read property 'length' of undefined
    c
    58 |
    59 | export function createGlowGeometry(geometry, size) {
    60 | // Gather vertexNormals from geometry.faces

61 | const glowGeometry = geometry.clone();
62 | const vertexNormals = new Array(glowGeometry.vertices.length);
63 | glowGeometry.faces.forEach((face) => {
64 | if (face instanceof Face3) {

2.) TypeError: Cannot read property 'updateCallbacks' of null
(anonymous function)
70 |
71 | // update callbacks
72 | useEffect(() => {

73 | const globe = globeRef.current;
| ^ 74 | globe.updateCallbacks({
75 | onClickMarker,
76 | onDefocus,

3.) TypeError: Cannot read property 'updateMarkers' of null
(anonymous function)
98 |
99 | // update markers
100 | useEffect(() => {

101 | const globe = globeRef.current;
| ^ 102 | globe.updateMarkers(markers);
103 | }, [markers]);
104 |

4.) TypeError: Cannot read property 'applyAnimations' of null
(anonymous function)
111 | // apply animations
112 | useEffect(() => {
113 | const globe = globeRef.current;

114 | return globe.applyAnimations(animations);
| ^ 115 | }, [animations]);
116 |
117 | return (

... and so on. I'll send them all if you need them.

the code is just the simpleGlobe version of your readme

Thanks for you help!

@malinantonsson
Copy link

Haha I have the same issue. Thought I was going crazy.

@malinantonsson
Copy link

@Zachweiss10 downgrading three to 0.109.0 worked for me.

@Zachweiss10
Copy link
Author

@malinantonsson Thank you! I'll give that a shot

@Zachweiss10
Copy link
Author

@malinantonsson That fixed it thank you! (not sure if I should leave this issue open as there are some compat. issues.

@malinantonsson
Copy link

@Zachweiss10 I would leave it open - if anything it would be good to mention it in the readme or something :)

@sloorush
Copy link

sloorush commented Apr 2, 2021

Good issue! Needs to be solved urgently as documentation wrt version of three has been mentioned wrongly

Will be sending a PR for this soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants