From e0a85c4343c23ed418bb08b4f2e57cca3e9fa2ef Mon Sep 17 00:00:00 2001
From: Florian Daniel Lucut <florian.lucut@edumail.at>
Date: Thu, 19 Dec 2024 23:49:50 +0100
Subject: [PATCH] fix attribute error in SdOptionCommon This fixes a bug, that
 whenever a SdOptionCommon object is called, the attribute "type" can be used.

---
 src/someipy/_internal/someip_sd_extractors.py |  8 ++++----
 src/someipy/_internal/someip_sd_option.py     | 16 +++++++++++++---
 2 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/src/someipy/_internal/someip_sd_extractors.py b/src/someipy/_internal/someip_sd_extractors.py
index e822f6a..1f0f53b 100644
--- a/src/someipy/_internal/someip_sd_extractors.py
+++ b/src/someipy/_internal/someip_sd_extractors.py
@@ -21,12 +21,12 @@
     SdEventGroupEntry,
     SdServiceEntry,
 )
-from .someip_sd_option import SdIPV4EndpointOption, SdOptionCommon, SdOptionType
+from .someip_sd_option import SdIPV4EndpointOption, SdOptionType, SdOptionInterface
 
 
 def option_runs(
     entry: Union[SdServiceEntry, SdEventGroupEntry], sd_message: SomeIpSdHeader
-) -> Iterable[Union[SdIPV4EndpointOption, SdOptionCommon]]:
+) -> Iterable[SdOptionInterface]:
     """This function performs the option runs for SD entries. It uses the
     start index and the number of options to iterate over the options in two runs"""
 
@@ -52,7 +52,7 @@ def extract_offered_services(someip_sd_header: SomeIpSdHeader) -> List[SdService
 
         options = option_runs(e, someip_sd_header)
         for option in options:
-            if option.sd_option_common.type == SdOptionType.IPV4_ENDPOINT:
+            if option.get_sd_option_type() == SdOptionType.IPV4_ENDPOINT:
                 endpoint = (
                     option.ipv4_address,
                     option.port,
@@ -68,7 +68,7 @@ def extract_offered_services(someip_sd_header: SomeIpSdHeader) -> List[SdService
                     protocol=protocol,
                 )
                 result.append(sd_offered_service)
-
+                
     return result
 
 
diff --git a/src/someipy/_internal/someip_sd_option.py b/src/someipy/_internal/someip_sd_option.py
index f422886..1c71948 100644
--- a/src/someipy/_internal/someip_sd_option.py
+++ b/src/someipy/_internal/someip_sd_option.py
@@ -13,7 +13,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
-
+from abc import ABC, abstractmethod
 from dataclasses import dataclass
 from enum import Enum
 from typing import TypeVar
@@ -36,9 +36,14 @@ class SdOptionType(Enum):
     IPV4_SD_ENDPOINT = 0x24  # TODO: not implemented
     IPV6_SD_ENDPOINT = 0x26  # TODO: not implemented
 
+class SdOptionInterface(ABC):
+    
+    @abstractmethod
+    def get_sd_option_type(self):
+        pass
 
 @dataclass
-class SdOptionCommon:
+class SdOptionCommon(SdOptionInterface):
     """This class represents the common part of all SD options
     including the length of the option in bytes, the type of the option (uint8)
     and a discardable flag (bool)"""
@@ -60,9 +65,11 @@ def to_buffer(self) -> bytes:
         discardable_flag_value = set_bit_at_position(0, 7, self.discardable_flag)
         return struct.pack(">HBB", self.length, self.type.value, discardable_flag_value)
 
+    def get_sd_option_type(self) -> SdOptionType:
+        return self.type
 
 @dataclass
-class SdIPV4EndpointOption:
+class SdIPV4EndpointOption(SdOptionInterface):
     sd_option_common: SdOptionCommon
     ipv4_address: ipaddress.IPv4Address
     protocol: TransportLayerProtocol
@@ -86,3 +93,6 @@ def to_buffer(self) -> bytes:
         return self.sd_option_common.to_buffer() + struct.pack(
             ">IBBH", int(self.ipv4_address), 0, self.protocol.value, self.port
         )
+    
+    def get_sd_option_type(self) -> SdOptionType:
+        return self.sd_option_common.type