Skip to content

Commit b74961f

Browse files
committed
Tidy up descriptions of breaking change
1 parent f2ee3d4 commit b74961f

File tree

2 files changed

+27
-37
lines changed

2 files changed

+27
-37
lines changed

CHANGELOG.md

+27-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22

33
## [0.11.0] - 2024-01-22
44

5+
### BREAKING
6+
7+
We fixed the `varity.vcf-to-hgvs` implementation. It is confusing to throw the
8+
exception in `vcf-variant->protein-hgvs` when a variant overlaps the exon-intron
9+
boundaries, even if coding DNA HGVS is available. So we changed the behavior to
10+
return protein HGVS as `nil`.
11+
512
### Fixed
613

714
- Return protein HGVS as `nil` if a variant overlaps exon-intron boundaries. [#89](https://github.com/chrovis/varity/pull/89)
@@ -15,7 +22,26 @@
1522

1623
## [0.10.0] - 2023-12-27
1724

18-
### Fixed
25+
### BREAKING
26+
27+
We introduced enhancements to the description of protein changes by
28+
`varity.vcf-to-hgvs`, specifically making deletions more clinically meaningful:
29+
30+
1. exon-intron boundary deletions:
31+
32+
The deletion that overlaps the exon-intron boundary will trigger an Exception
33+
because alterations affecting the splice sites are predicted to be splicing
34+
abnormalities.
35+
36+
2. stop codon deletions:
37+
38+
In cases where deletions contain a stop codon, `varity.vcf-to-hgvs` generates
39+
the following outputs based on the alteration sequence:
40+
41+
- If the alteration sequence contains a stop codon, varity outputs as deletion-insertion.
42+
- Otherwise, this outputs `p.?`.
43+
44+
### Fixed
1945

2046
- Fix upstream and downstream sequence of sequence-info and delins process. [#81](https://github.com/chrovis/varity/pull/81)
2147
- Fix boundary of exon/intron determining process. [#82](https://github.com/chrovis/varity/pull/82)

README.md

-36
Original file line numberDiff line numberDiff line change
@@ -34,42 +34,6 @@ To use varity with Clojure 1.8, you must include a dependency on
3434
We fixed the `varity.vcf-to-hgvs` implementation.
3535
It is confusing to throw the exception in `vcf-variant->protein-hgvs` when a variant overlaps the exon-intron boundaries, even if coding DNA HGVS is available. So we changed the behavior to return protein HGVS as `nil`.
3636

37-
## Breaking changes in 0.10.0
38-
39-
We introduced enhancements to the description of protein changes by `varity.vcf-to-hgvs`, specifically making deletions more clinically meaningful:
40-
41-
1. exon-intron boundary deletions:
42-
43-
The deletion that overlaps the exon-intron boundary will trigger an Exception because alterations affecting the splice sites are predicted to be splicing abnormalities.
44-
45-
2. stop codon deletions:
46-
47-
In cases where deletions contain a stop codon, `varity.vcf-to-hgvs` generates the following outputs based on the alteration sequence:
48-
49-
- If the alteration sequence contains a stop codon, varity outputs as deletion-insertion.
50-
- Otherwise, this outputs `p.?`.
51-
52-
## Breaking changes in 0.9.0
53-
54-
The default value of `:prefer-deletion?` option is changed to `false`.
55-
56-
```clojure
57-
(require '[varity.vcf-to-hgvs :as v2h])
58-
59-
(v2h/vcf-variant->coding-dna-hgvs {:chr "chr7", :pos 140924774, :ref "GGGAGGC", :alt "G"}
60-
"path/to/hg38.fa" "path/to/refGene.txt.gz")
61-
;;=> (#clj-hgvs/hgvs "NM_004333:c.-95GCCTCC[3]")
62-
```
63-
64-
If you hope the previous behavior, specify `:prefer-deletion? true`.
65-
66-
```clojure
67-
(v2h/vcf-variant->coding-dna-hgvs {:chr "chr7", :pos 140924774, :ref "GGGAGGC", :alt "G"}
68-
"path/to/hg38.fa" "path/to/refGene.txt.gz"
69-
{:prefer-deletion? true})
70-
;;=> (#clj-hgvs/hgvs "NM_004333:c.-77_-72delGCCTCC")
71-
```
72-
7337
## Usage
7438

7539
### Documentation

0 commit comments

Comments
 (0)