Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow converting src height/width to viewBox #4

Open
shgysk8zer0 opened this issue Feb 13, 2016 · 0 comments
Open

Allow converting src height/width to viewBox #4

shgysk8zer0 opened this issue Feb 13, 2016 · 0 comments

Comments

@shgysk8zer0
Copy link

I ran into this when attempting to generate from Octicons. Since they do not have a viewBox attribute, the resulting <symbol>s do not work well.

This can be set using the height and width attributes, however.

`viewBox="0 0 ${icon.width} ${icon.height}"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shgysk8zer0