-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Description
Expected:
Project is written with testable code that doesn't require integration test that use file-comparison (which is very brittle) to validate regex. For example, in inline.js, isolate all methods that match on regex whenever possible, and unit test them with minimal dependencies that can be injected if necessary.
Actual:
"grunt test" uses integration tests as a way to validate regex matching. This is a poor practice. It's up to you to ask a project contributor how to de-couple the dependencies and write better tests.
versions:
- affects all versions of this project
Metadata
Metadata
Assignees
Labels
No labels