Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in unit tests #115

Open
nranas opened this issue May 5, 2017 · 1 comment
Open

Fix warnings in unit tests #115

nranas opened this issue May 5, 2017 · 1 comment

Comments

@nranas
Copy link
Contributor

nranas commented May 5, 2017

We're getting these currently:

PASS  __tests__/am-pm-tests..js
  ● Console
    console.error node_modules/fbjs/lib/warning.js:36
      Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning.

The tests are still passing but we should get rid of the warnings since they will eventually turn in to errors.

@nranas
Copy link
Contributor Author

nranas commented Jun 1, 2017

I have fixed most of the warnings in #122. The few that are still left comes from react-widgets which have fixed them in version 4 (currently on rc6). When v4 is stable we should upgrade to that and the warnings should disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants