Skip to content
This repository has been archived by the owner on Apr 13, 2019. It is now read-only.

IRCv3 tags broken if tag value contains a colon #250

Open
aetaric opened this issue Aug 17, 2017 · 4 comments
Open

IRCv3 tags broken if tag value contains a colon #250

aetaric opened this issue Aug 17, 2017 · 4 comments

Comments

@aetaric
Copy link

aetaric commented Aug 17, 2017

It looks like the regex on line 100 of lib/cinch/message.rb is broken for twitch IRCv3 when emotes are used in the message:

Example message that breaks the regex:
@badges=moderator/1,subscriber/24,bits/50000;color=#D63F50;display-name=CyclopsDragon;emotes=15017:11-16;id=e4964802-5310-449d-b8f1-52be38ff1d26;mod=1;room-id=21836069;sent-ts=1502929472853;subscriber=1;tmi-sent-ts=1502929475647;turbo=0;user-id=6342406;user-type=mod :cyclopsdragon!cyclopsdragon@cyclopsdragon.tmi.twitch.tv PRIVMSG #geoff :hi gibeDu

On Twitch's IRC the emotes tag will contain a colon which breaks the regex preventing the message from being parsed.

@Defman21
Copy link
Contributor

http://regexr.com/3giql

I built a new regex. Looks like it's working. Could you test it with some other messages? :)

@aetaric
Copy link
Author

aetaric commented Aug 17, 2017

Not sure if that regex is used to parse the messages on login, but the bot is no longer joining channels or requesting caps with that regex in place.

@craysiii
Copy link

Pretty sure I've fixed it here: craysiii/cinch@72c3ee6

Not sure if I should make a pull request, haven't tested it on a "normal" IRC network.

@aetaric
Copy link
Author

aetaric commented Aug 23, 2017

Confirmed working on Twitch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants