Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoD1_solidsWithTIN #37

Closed
AdrianKriger opened this issue Jul 27, 2021 · 5 comments
Closed

LoD1_solidsWithTIN #37

AdrianKriger opened this issue Jul 27, 2021 · 5 comments

Comments

@AdrianKriger
Copy link

AdrianKriger commented Jul 27, 2021

Hi.
I am unable to load a LoD1 CityModel into qgis successfully.
qgis=Zürich in a conda environment. (I've tried with an earlier version but it keeps crashing)
cityJSON=here.

The model loads into ninja. With qgis; the buildings (solids) fail to display. The tinrelief does.
The only settings: are defining the crs (EPSG:32733) and Split layers according to object type.

I don't know if the following is relevant:
When passing parsing the model through val3dity the tinrelief fails ~ Error 305 MULTIPLE_CONNECTED_COMPONENTS.
Is this because the tin has isolated features (courtyards ~ interior of buildings) disconnected from the larger terrain?

Have I created the CityObject incorrectly? or am I not defining the qgis parameters correctly?

Your attention is appreciated.
Adrian.

@AdrianKriger AdrianKriger changed the title LoD1_solidsWithtin LoD1_solidsWithTIN Jul 27, 2021
@Athelena
Copy link
Contributor

Athelena commented Jul 27, 2021

I just had a quick play and I noticed that if you remove from the building attributes "osm_tags" then the buildings can be visualised in QGIS. Can't tell you why though 😅 @liberostelios will know better for sure. I'm guessing it's something to do with parsing the nested hierarchy.

@AdrianKriger
Copy link
Author

AdrianKriger commented Jul 27, 2021

One thumbs up @Athelena - for the super service and a 😄 for the grammar.

Do you suggest non-nested attributes? Should I write the CityJSON differently?
How did you remove the attributes?

@Athelena
Copy link
Contributor

Haha, no worries! Happy to help 😄

So what you store in your file is not wrong, you're allowed to have nested attributes according to the schema, I validated it to make sure. @liberostelios said he will fix this issue soon since the plugin should be able to handle nested attributes. I also listed it as an issue for ninja (#57) since reading them as just a string is perhaps not super useful either.

For now I suggest perhaps un-nesting the attributes and maybe you can instead group them as such: "osm_tags_addr:city", "osm_tags_addr:postcode", etc. This will help if you wish to use them as attributes within QGIS.

I just took a small subset of 5 buildings with cjio and played with attributes manually to check if nesting was the issue. But I think you can easily just change this in your script?

@AdrianKriger
Copy link
Author

AdrianKriger commented Jul 29, 2021

@Athelena. Lets leave the result as is - I like the nested attributes. It's intuitive.
What I will do is add a function that transforms the CItyModel to a "flatter" data-structure; should the user choose.

You have been extremely helpful. Thank you.

@Athelena
Copy link
Contributor

No problem! Always happy to help and it's nice to see people developing open data and open code 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants