Help with refactoring large match

[ghenry]

Hi all,

Very new to Rust and clap. What design pattern should I reach for to make this smaller and move out of my main?

https://github.com/ghenry/CallSwitchOne-CLI/blob/0fa1d90b4c65a94d86772f4c8e10d33659576dc7/src/main.rs#L33

I'll be mapping a lot of commands, subcommands and args to these API endpoints:

https://www.callswitchone.com/api-docs/

Thanks.

[ghenry]

I think I'll switch to a hashmap with the enums as keys and the API endpoint URL as the value. Like a dispatch table. Not really related to clap I know, but curious to what others are doing here.

Thanks for listening :)

[epage]

Instead of a hash map, you can

impl Endpoint {
    fn url(&self) -> String {
    }
}

You could even implement it directly on cli::ExtensionCommands rather than converting from one enum to another.

[ghenry]

Could you give me a usage example for that?

Something like:

#[derive(Debug, Subcommand)]
pub enum ExtensionCommands {
    /// List all SIP Extensions
    List,
    /// List the status of all SIP Extensions
    ListStatus,
    /// Get the details of a SIP Extension
    Detail(DetailArgs),
    /// Get the status of a SIP Extension
    DetailStatus(DetailArgs),
    /// Get the queue availability of a SIP Extension
    QueueStatus(DetailArgs),
    /// Get the next valid SIP Extension Number
    Next,
}

impl ExtensionCommands {
    fn detail_url(&self, uuid: Uuid) -> String {
        format!("{}/voip/user/{}", API_URL, uuid)
    }
}

and then:

            cli::ExtensionCommands::Detail(detail_args) => {
                if cli.debug > 0 {
                    println!("Details of SIP Extension");
                }
                requests::readonly::get(&config, &cli.debug, true,  cli::ExtensionCommands.details_url(details_args.uuid)).await                
            }

[epage]

Something like:

cli::Commands::Extension(args) => {
    if cli.debug > 0 {
        println!("{}", args.command);
    }
    let url = args.command.detailed_url();
    println!(
        "{}",
        requests::readonly::get(&config, &cli.debug, true, &url).await
    );
},

[ghenry]

This is tidier but not much shorter :-)