From dcf6b8d386ddf20c9df45da4fc9cd90ee4fc4a86 Mon Sep 17 00:00:00 2001 From: Dave Johansen Date: Mon, 15 Jul 2019 16:07:06 -0600 Subject: [PATCH 1/3] Don't specify width and use width to calculate percent --- index.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/index.js b/index.js index 240ef30..89fc4ec 100644 --- a/index.js +++ b/index.js @@ -23,7 +23,6 @@ module.exports = function ProgressBarPlugin(options) { var customSummary = options.customSummary; delete options.format; - delete options.total; delete options.summary; delete options.summaryContent; delete options.customSummary; @@ -31,7 +30,6 @@ module.exports = function ProgressBarPlugin(options) { var barOptions = Object.assign({ complete: '=', incomplete: ' ', - width: 20, total: 100, clear: true }, options); @@ -47,7 +45,7 @@ module.exports = function ProgressBarPlugin(options) { stream.write('\n'); } - var newPercent = Math.floor(percent * barOptions.width); + var newPercent = Math.floor(percent * barOptions.total); if (lastPercent < newPercent || newPercent === 0) { bar.update(percent, { From 3abe884e4b7d6cdf60f62b537daef33f01839e36 Mon Sep 17 00:00:00 2001 From: Dave Johansen Date: Mon, 15 Jul 2019 16:14:31 -0600 Subject: [PATCH 2/3] Update dependencies --- package-lock.json | 73 ++++++++++++++++++++++++----------------------- package.json | 4 +-- 2 files changed, 39 insertions(+), 38 deletions(-) diff --git a/package-lock.json b/package-lock.json index 59ba69c..99ac718 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4,28 +4,37 @@ "lockfileVersion": 1, "requires": true, "dependencies": { - "ansi-regex": { - "version": "2.1.1", - "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-2.1.1.tgz", - "integrity": "sha1-w7M6te42DYbg5ijwRorn7yfWVN8=" - }, "ansi-styles": { - "version": "2.2.1", - "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-2.2.1.tgz", - "integrity": "sha1-tDLdM1i2NM914eRmQ2gkBTPB3b4=" + "version": "3.2.1", + "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-3.2.1.tgz", + "integrity": "sha512-VT0ZI6kZRdTh8YyJw3SMbYm/u+NqfsAxEpWO0Pf9sq8/e94WxxOpPKx9FR1FlyCtOVDNOQ+8ntlqFxiRc+r5qA==", + "requires": { + "color-convert": "^1.9.0" + } }, "chalk": { - "version": "1.1.3", - "resolved": "https://registry.npmjs.org/chalk/-/chalk-1.1.3.tgz", - "integrity": "sha1-qBFcVeSnAv5NFQq9OHKCKn4J/Jg=", + "version": "2.4.2", + "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz", + "integrity": "sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==", + "requires": { + "ansi-styles": "^3.2.1", + "escape-string-regexp": "^1.0.5", + "supports-color": "^5.3.0" + } + }, + "color-convert": { + "version": "1.9.3", + "resolved": "https://registry.npmjs.org/color-convert/-/color-convert-1.9.3.tgz", + "integrity": "sha512-QfAUtd+vFdAtFQcC8CCyYt1fYWxSqAiK2cSD6zDB8N3cpsEBAvRxp9zOGg6G/SHHJYAT88/az/IuDGALsNVbGg==", "requires": { - "ansi-styles": "^2.2.1", - "escape-string-regexp": "^1.0.2", - "has-ansi": "^2.0.0", - "strip-ansi": "^3.0.0", - "supports-color": "^2.0.0" + "color-name": "1.1.3" } }, + "color-name": { + "version": "1.1.3", + "resolved": "https://registry.npmjs.org/color-name/-/color-name-1.1.3.tgz", + "integrity": "sha1-p9BVi9icQveV3UIyj3QIMcpTvCU=" + }, "define-properties": { "version": "1.1.3", "resolved": "https://registry.npmjs.org/define-properties/-/define-properties-1.1.3.tgz", @@ -44,13 +53,10 @@ "resolved": "https://registry.npmjs.org/function-bind/-/function-bind-1.1.1.tgz", "integrity": "sha512-yIovAzMX49sF8Yl58fSCWJ5svSLuaibPxXQJFLmBObTuCr0Mf1KiPopGM9NiFjiYBCbfaa2Fh6breQ6ANVTI0A==" }, - "has-ansi": { - "version": "2.0.0", - "resolved": "https://registry.npmjs.org/has-ansi/-/has-ansi-2.0.0.tgz", - "integrity": "sha1-NPUEnOHs3ysGSa8+8k5F7TVBbZE=", - "requires": { - "ansi-regex": "^2.0.0" - } + "has-flag": { + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-3.0.0.tgz", + "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0=" }, "has-symbols": { "version": "1.0.0", @@ -74,22 +80,17 @@ } }, "progress": { - "version": "1.1.8", - "resolved": "https://registry.npmjs.org/progress/-/progress-1.1.8.tgz", - "integrity": "sha1-4mDHj2Fhzdmw5WzD4Khd4Xx6V74=" + "version": "2.0.3", + "resolved": "https://registry.npmjs.org/progress/-/progress-2.0.3.tgz", + "integrity": "sha512-7PiHtLll5LdnKIMw100I+8xJXR5gW2QwWYkT6iJva0bXitZKa/XMrSbdmg3r2Xnaidz9Qumd0VPaMrZlF9V9sA==" }, - "strip-ansi": { - "version": "3.0.1", - "resolved": "https://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz", - "integrity": "sha1-ajhfuIU9lS1f8F0Oiq+UJ43GPc8=", + "supports-color": { + "version": "5.5.0", + "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-5.5.0.tgz", + "integrity": "sha512-QjVjwdXIt408MIiAqCX4oUKsgU2EqAGzs2Ppkm4aQYbjm+ZEWEcW4SfFNTr4uMNZma0ey4f5lgLrkB0aX0QMow==", "requires": { - "ansi-regex": "^2.0.0" + "has-flag": "^3.0.0" } - }, - "supports-color": { - "version": "2.0.0", - "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-2.0.0.tgz", - "integrity": "sha1-U10EXOa2Nj+kARcIRimZXp3zJMc=" } } } diff --git a/package.json b/package.json index cc2d1f9..7182cb5 100644 --- a/package.json +++ b/package.json @@ -23,9 +23,9 @@ }, "homepage": "https://github.com/clessg/progress-bar-webpack-plugin#readme", "dependencies": { - "chalk": "^1.1.1", + "chalk": "^2.0.0", "object.assign": "^4.0.1", - "progress": "^1.1.8" + "progress": "^2.0.0" }, "peerDependencies": { "webpack": "^1.3.0 || ^2 || ^3 || ^4" From 048438839c2ea77f26236ddb530a0d0ca41b1162 Mon Sep 17 00:00:00 2001 From: Dave Johansen Date: Mon, 15 Jul 2019 17:26:23 -0600 Subject: [PATCH 3/3] Don't need object.assign since all currently supported versions of node have it --- index.js | 2 -- package-lock.json | 34 ---------------------------------- package.json | 1 - 3 files changed, 37 deletions(-) diff --git a/index.js b/index.js index 89fc4ec..0c85a40 100644 --- a/index.js +++ b/index.js @@ -2,8 +2,6 @@ var ProgressBar = require('progress'); var chalk = require('chalk'); var webpack = require('webpack'); -require('object.assign').shim(); - module.exports = function ProgressBarPlugin(options) { options = options || {}; diff --git a/package-lock.json b/package-lock.json index 99ac718..81721bb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -35,50 +35,16 @@ "resolved": "https://registry.npmjs.org/color-name/-/color-name-1.1.3.tgz", "integrity": "sha1-p9BVi9icQveV3UIyj3QIMcpTvCU=" }, - "define-properties": { - "version": "1.1.3", - "resolved": "https://registry.npmjs.org/define-properties/-/define-properties-1.1.3.tgz", - "integrity": "sha512-3MqfYKj2lLzdMSf8ZIZE/V+Zuy+BgD6f164e8K2w7dgnpKArBDerGYpM46IYYcjnkdPNMjPk9A6VFB8+3SKlXQ==", - "requires": { - "object-keys": "^1.0.12" - } - }, "escape-string-regexp": { "version": "1.0.5", "resolved": "https://registry.npmjs.org/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz", "integrity": "sha1-G2HAViGQqN/2rjuyzwIAyhMLhtQ=" }, - "function-bind": { - "version": "1.1.1", - "resolved": "https://registry.npmjs.org/function-bind/-/function-bind-1.1.1.tgz", - "integrity": "sha512-yIovAzMX49sF8Yl58fSCWJ5svSLuaibPxXQJFLmBObTuCr0Mf1KiPopGM9NiFjiYBCbfaa2Fh6breQ6ANVTI0A==" - }, "has-flag": { "version": "3.0.0", "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-3.0.0.tgz", "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0=" }, - "has-symbols": { - "version": "1.0.0", - "resolved": "https://registry.npmjs.org/has-symbols/-/has-symbols-1.0.0.tgz", - "integrity": "sha1-uhqPGvKg/DllD1yFA2dwQSIGO0Q=" - }, - "object-keys": { - "version": "1.0.12", - "resolved": "https://registry.npmjs.org/object-keys/-/object-keys-1.0.12.tgz", - "integrity": "sha512-FTMyFUm2wBcGHnH2eXmz7tC6IwlqQZ6mVZ+6dm6vZ4IQIHjs6FdNsQBuKGPuUUUY6NfJw2PshC08Tn6LzLDOag==" - }, - "object.assign": { - "version": "4.1.0", - "resolved": "https://registry.npmjs.org/object.assign/-/object.assign-4.1.0.tgz", - "integrity": "sha512-exHJeq6kBKj58mqGyTQ9DFvrZC/eR6OwxzoM9YRoGBqrXYonaFyGiFMuc9VZrXf7DarreEwMpurG3dd+CNyW5w==", - "requires": { - "define-properties": "^1.1.2", - "function-bind": "^1.1.1", - "has-symbols": "^1.0.0", - "object-keys": "^1.0.11" - } - }, "progress": { "version": "2.0.3", "resolved": "https://registry.npmjs.org/progress/-/progress-2.0.3.tgz", diff --git a/package.json b/package.json index 7182cb5..0c981bd 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,6 @@ "homepage": "https://github.com/clessg/progress-bar-webpack-plugin#readme", "dependencies": { "chalk": "^2.0.0", - "object.assign": "^4.0.1", "progress": "^2.0.0" }, "peerDependencies": {