From 5df0d69feb8e96a9e965ebd14792a560d01e38e9 Mon Sep 17 00:00:00 2001 From: Matt Sherman Date: Sun, 6 Jul 2014 23:05:16 -0400 Subject: [PATCH] per @infogulch, error check was a no-op --- typewriter/parser.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/typewriter/parser.go b/typewriter/parser.go index fda4b90..4935564 100644 --- a/typewriter/parser.go +++ b/typewriter/parser.go @@ -86,8 +86,9 @@ func getTypes(directive string, filter func(os.FileInfo) bool) ([]Type, error) { known := err == nil if !known { + // really shouldn't happen, since the type came from the ast in the first place err = fmt.Errorf("failed to evaluate type %s (%s)", typ.Name, err) - continue + return typs, err } typ.comparable = isComparable(t)