Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of commented code with #_ #47

Closed
mtsbarbosa opened this issue Apr 14, 2024 · 6 comments
Closed

Change color of commented code with #_ #47

mtsbarbosa opened this issue Apr 14, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mtsbarbosa
Copy link

Is your feature request related to a problem? Please describe.
When adding #_ before a code to comment it, the color does not change

Describe the solution you'd like
To have the same gray coloring of the ; commented lines

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@mtsbarbosa mtsbarbosa added the enhancement New feature or request label Apr 14, 2024
@ericdallo ericdallo added the good first issue Good for newcomers label Apr 15, 2024
@ericdallo ericdallo moved this to Ready for development in clojure-lsp-intellij Apr 15, 2024
@ericdallo
Copy link
Member

I'm aware of this bug but could not find a way to fix it yet, we should change IntelliJ lexer used in our library to achieve that

@nukurt
Copy link

nukurt commented Nov 11, 2024

Feel free to wander around the wreckage of https://github.com/projectileboy/clo-jet/tree/master/src/com/bitbakery/clojet/lexer; not sure if there is anything useful in there or not, but the lexer and parser were pretty solid iirc.

@ericdallo
Copy link
Member

That should help @nukurt! will take a look

@ericdallo
Copy link
Member

ericdallo commented Nov 11, 2024

Unfortunately, I think that lexer doesn't support form comments as well :/

@github-project-automation github-project-automation bot moved this from Ready for development to ✅ Done in clojure-lsp-intellij Nov 11, 2024
@ericdallo
Copy link
Member

@mtsbarbosa I managed to partially fix it supporting one level of form comment which should attend most of the cases, feel free to create a new issue for the remaining feature

2024-11-11_19-05

@mefryar
Copy link

mefryar commented Nov 13, 2024

Thanks, @ericdallo! I've created #58 to request support for changing to grey single forms that are more than one string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants