CLJS-3466: support qualified method in return position

Author: borkdude

src/main/clojure/cljs/analyzer.cljc

@@ -4141,7 +4141,7 @@
               {:op    :qualified-method
                :env   env
                :form  sym
-               :class (analyze-symbol env (symbol sym-ns))}
+               :class (analyze-symbol (assoc env :context :expr) (symbol sym-ns))}
               (if (= "new" sym-name)
                 {:kind :new
                  :name (symbol sym-name)}

src/test/cljs/cljs/qualified_method_test.cljs

@@ -0,0 +1,17 @@
+;   Copyright (c) Rich Hickey. All rights reserved.
+;   The use and distribution terms for this software are covered by the
+;   Eclipse Public License 1.0 (http://opensource.org/licenses/eclipse-1.0.php)
+;   which can be found in the file epl-v10.html at the root of this distribution.
+;   By using this software in any fashion, you are agreeing to be bound by
+;   the terms of this license.
+;   You must not remove this notice, or any other, from this software.
+
+(ns cljs.qualified-method-test
+  (:refer-global :only [String])
+  (:require [cljs.test :as test :refer-macros [deftest testing is]]))
+
+(deftest qualified-method-return-position-test
+  (testing "qualified method returned from function to force it in return position"
+    (let [f (fn [] String/.toUpperCase)
+          m (f)]
+      (is (= "FOO" (m "foo"))))))

src/test/cljs/lite_test_runner.cljs

@@ -7,7 +7,8 @@
 ;; You must not remove this notice, or any other, from this software.
 
 (ns lite-test-runner
-  (:require [cljs.proxy-test]
+  (:require [cljs.qualified-method-test]
+            [cljs.proxy-test]
             [cljs.test :refer-macros [run-tests]]
             [cljs.apply-test]
             [cljs.primitives-test]
@@ -73,6 +74,7 @@
   (enable-console-print!))
 
 (run-tests
+  'cljs.qualified-method-test
   'cljs.proxy-test
   'cljs.apply-test
   'cljs.primitives-test

src/test/cljs/test_runner.cljs

@@ -7,7 +7,8 @@
 ;; You must not remove this notice, or any other, from this software.
 
 (ns test-runner
-  (:require [cljs.proxy-test]
+  (:require [cljs.qualified-method-test]
+            [cljs.proxy-test]
             [cljs.test :refer-macros [run-tests]]
             [cljs.apply-test]
             [cljs.primitives-test]
@@ -72,6 +73,7 @@
   (enable-console-print!))
 
 (run-tests
+  'cljs.qualified-method-test
   'cljs.proxy-test
   'cljs.apply-test
   'cljs.primitives-test