Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gpuInfo, disk, keyvalueList at vmspec of gcp, aws, alibaba #1403

Merged
merged 13 commits into from
Dec 26, 2024

Conversation

MZC-CSC
Copy link
Contributor

@MZC-CSC MZC-CSC commented Dec 19, 2024

vmSpecInfo.Disk 은 "-1" 로 설정
vmSpecInfo.VCpu.Clock 은 없음
vmSpecInfo.Gpu.[]. gpu정보추가

// gcp 같은경우 n1 타입만 그래픽 카드가 추가 되며
// 1. n1타입인지 확인하는 로직 필요
-> 공식문서에서는 n1타입에 대한 설명이 있으나 API상으로는 존재하지 않음
// 2. 해당 카드에 관련된 정보를 조회하는 로직필요.
-> 카드에 관현 정보는 acceleratorTypes.list , get을 통해 조회는 가능하나 추상화된 정보는 들어있지 않음.
// 3. 해당 리스트를 조회하고 해당 GPU를 선택하는 로직
-> 추상화된 정보가 들어있지 않아 조회가 불필요

image

@powerkimhub powerkimhub self-requested a review December 19, 2024 16:25
@powerkimhub
Copy link
Member

@MZC-CSC

  • Mfr, Model 값: ToUpper 처리 부탁 드립니다.
  • Guide에 명시적으로 표현이 되어 있지 않았던 점 양해 부탁 드립니다.
    • Guide는 보완하겠습니다.

Copy link

Could you please check and revise Korean texts?
Note - All output of print and log statements should be in English. 😉

cloud-control-manager/cloud-driver/drivers/aws/resources/VMSpecHandler.go

24:+		gpuInfo.Mfr = "NA" // 문자열 값 없을 경우 "NA"
31:+		gpuInfo.Model = "NA" // 문자열 값 없을 경우 "NA"
39:+	//fmt.Println("=======[EC2 응답] ==========")

@MZC-CSC
Copy link
Contributor Author

MZC-CSC commented Dec 20, 2024

AWS : [Metadata: VMSpec] Enhance Supported VM Spec Info

  • String 값 없으면 "NA" 처리
  • 숫자 값 없으면 -1 처리
  • GpuInfo 없으면 nil 처리
  • GpuInfo 존재하면, 각 항목에 대해서 없는 항목들은 "NA" 또는 -1 처리
  • VCpuInfo 각 항목에 대해서 없는 항목은 -1 처리

Related Issue: #1396 #1399

Copy link

Could you please check and revise Korean texts?
Note - All output of print and log statements should be in English. 😉

cloud-control-manager/cloud-driver/drivers/aws/resources/VMSpecHandler.go

39:+	//fmt.Println("=======[EC2 응답] ==========")

@MZC-CSC
Copy link
Contributor Author

MZC-CSC commented Dec 23, 2024

GCP에서
Mfr, Model 값: ToUpper 처리
GuestAcceleratorCount 기본값 -1로 설정

@powerkimhub powerkimhub changed the title add gpuInfo, disk, keyvalueList at vmspec of gcp add gpuInfo, disk, keyvalueList at vmspec of gcp, aws Dec 23, 2024
@MZC-CSC
Copy link
Contributor Author

MZC-CSC commented Dec 24, 2024

ALIBABA
mem, disk, count, clock, count, men단위 확인
기본값 처리

Disk 정보 -> instanceTypeInfo.LocalStorageCapacity로 처리 (단위 GB로 변경)

@powerkimhub powerkimhub merged commit cbdc9af into cloud-barista:master Dec 26, 2024
3 checks passed
@MZC-CSC MZC-CSC changed the title add gpuInfo, disk, keyvalueList at vmspec of gcp, aws add gpuInfo, disk, keyvalueList at vmspec of gcp, aws, alibaba Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants