Add minion_manager.rpc.client.py/tasks.py unit tests
#321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaelabalutoiu
force-pushed
the
add-minion-manager-unit-tests
branch
from
5ad95ce
to
22807f0
Compare
Dany9966
requested changes
Jul 3, 2024
exception message for proper formatting. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
add-minion-manager-unit-tests
branch
from
22807f0
to
092aac2
Compare
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
add-minion-manager-unit-tests
branch
from
092aac2
to
4f3b9f5
Compare
mihaelabalutoiu
commented
Aug 26, 2024
Dany9966
requested changes
Aug 30, 2024
mihaelabalutoiu
force-pushed
the
add-minion-manager-unit-tests
branch
from
4f3b9f5
to
024a2a0
Compare
|
Mostly lgtm, you only have a little missed case in |
module Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
add-minion-manager-unit-tests
branch
from
024a2a0
to
edb08b4
Compare
Dany9966
requested changes
Sep 11, 2024
Comment on lines
+1678
to
+1679
| mock_get_minion_machine.return_value = self.minion_machine | ||
| mock_execute.side_effect = CoriolisTestException |
There was a problem hiding this comment.
I don't get what you're testing here. You mock the tested method, make it raise and then check that the raise has occurred?
For this case, you need to:
- set
mock_get_minion_machine.return_value = None; - remove the
mock_executeentirely; - keep
_fail_on_erroronTrue; - Check that the call raises
InvalidMinionMachineState.
There was a problem hiding this comment.
Nevermind this, this case was already covered. This case is also good. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test cases for the following module:
minion_manager.rpc.tasks.pyminion_manager.rpc.client.py