Fix migration reservation deletion on internal cancellations #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes sure that the migration reservation deletion is done on any migration task cancellation. Prior to this, internal cancellations (i.e. KeyboardInterrupt signals) that were raised internally did not result in a migration reservation deletion, leaving said cancelled migration licences as consumed. The reservation deletion was moved in the cancellation confirmation operation on conductor side, so all cancellation signals will be included in making sure the cancelled migration licence will be reverted.
Dany9966
force-pushed
the
migration-cancellation-licence-fix
branch
from
3e49932
to
e8d6fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes sure that the migration reservation deletion is done on any migration task cancellation. Prior to this, internal cancellations (i.e. KeyboardInterrupt signals) that were raised internally did not result in a migration reservation deletion, leaving said cancelled migration licences as consumed. The reservation deletion was moved in the cancellation confirmation operation on conductor side, so all cancellation signals will be included in making sure the cancelled migration licence will be reverted.