Fix child process killing and improve session documentation #348
+375
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace process group kill with recursive /proc/PID/task/PID/children traversal. This handles processes that spawn their own process groups (e.g., children started with & inside bash -c). Removes set -m since process groups are no longer used for killing.
Add comprehensive documentation for developers unfamiliar with bash: - Glossary of bash concepts (FIFOs, backgrounding, redirections, etc.) - Linux process concepts (/proc filesystem, process tree killing) - Data flow diagrams for FIFO-based stdout/stderr separation - Annotated breakdown of the labeler pattern one-liner - Explanation of depth-first kill order for process trees
Update SESSION_EXECUTION.md: - Rewrite to focus on architecture and design decisions - Add tables for execution mode comparison - Document process termination strategy (/proc tree walking) - Add TypeScript patterns section (shell death sentinel, hybrid detection) - Add cross-references to source files Update session.ts: - Add cross-reference to architecture doc in file header - Document shellExitedPromise as 'sentinel Promise' pattern - Clarify waitForExitCode detection strategy (4 mechanisms) - Clarify waitForPidViaPipe fallback chain
🦋 Changeset detectedLatest commit: b4d83ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
🐳 Docker Images PublishedDefault: FROM cloudflare/sandbox:0.0.0-pr-348-5f750dbWith Python: FROM cloudflare/sandbox:0.0.0-pr-348-5f750db-pythonWith OpenCode: FROM cloudflare/sandbox:0.0.0-pr-348-5f750db-opencodeVersion: Use the 📦 Standalone BinaryFor arbitrary Dockerfiles: COPY --from=cloudflare/sandbox:0.0.0-pr-348-5f750db /container-server/sandbox /sandbox
ENTRYPOINT ["/sandbox"]Download via GitHub CLI: gh run download 20957540665 -n sandbox-binaryExtract from Docker: docker run --rm cloudflare/sandbox:0.0.0-pr-348-5f750db cat /container-server/sandbox > sandbox && chmod +x sandbox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
&insidebash -c "..."survived when parent was killedChanges
Bug Fix
Replaced
set -mjob control approach with/proctree walking to kill all descendant processes. The previous approach failed for processes that spawn their own process groups (e.g.,bash -c "sleep 100 &").Documentation for Non-Bash Experts
Added to
session.ts:$!,$?, redirections, signals, etc.)Documentation Maintainability
SESSION_EXECUTION.mdto focus on architecture and design decisionsTesting