From aefa9f880cafb3757a1660864230ded031f1736c Mon Sep 17 00:00:00 2001
From: Yagiz Nizipli <yagiz@cloudflare.com>
Date: Mon, 28 Oct 2024 11:47:33 -0400
Subject: [PATCH] fix node:util/types exports (#3016)

---
 src/node/util/types.ts                        | 45 ++++++++++++++++++-
 .../api/node/tests/util-nodejs-test.js        |  2 +
 2 files changed, 46 insertions(+), 1 deletion(-)

diff --git a/src/node/util/types.ts b/src/node/util/types.ts
index 36d66e848be..0d94f77f81f 100644
--- a/src/node/util/types.ts
+++ b/src/node/util/types.ts
@@ -23,7 +23,50 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-/* todo: the following is adopted code, enabling linting one day */
 export * from 'node-internal:internal_types';
 import { default as types } from 'node-internal:internal_types';
+export {
+  isCryptoKey,
+  isKeyObject,
+  isAsyncFunction,
+  isGeneratorFunction,
+  isGeneratorObject,
+  isAnyArrayBuffer,
+  isArrayBuffer,
+  isArgumentsObject,
+  isBoxedPrimitive,
+  isDataView,
+  isMap,
+  isMapIterator,
+  isModuleNamespaceObject,
+  isNativeError,
+  isPromise,
+  isProxy,
+  isSet,
+  isSetIterator,
+  isSharedArrayBuffer,
+  isWeakMap,
+  isWeakSet,
+  isRegExp,
+  isDate,
+  isStringObject,
+  isSymbolObject,
+  isNumberObject,
+  isBooleanObject,
+  isBigIntObject,
+  isArrayBufferView,
+  isBigInt64Array,
+  isBigUint64Array,
+  isFloat32Array,
+  isFloat64Array,
+  isInt8Array,
+  isInt16Array,
+  isInt32Array,
+  isTypedArray,
+  isUint8Array,
+  isUint8ClampedArray,
+  isUint16Array,
+  isUint32Array,
+  isExternal,
+} from 'node-internal:internal_types';
 export default types;
diff --git a/src/workerd/api/node/tests/util-nodejs-test.js b/src/workerd/api/node/tests/util-nodejs-test.js
index 068cb2ba3fc..b145798e14e 100644
--- a/src/workerd/api/node/tests/util-nodejs-test.js
+++ b/src/workerd/api/node/tests/util-nodejs-test.js
@@ -4373,5 +4373,7 @@ export const makeSureUtilTypesIsExported = {
   async test() {
     const types = await import('node:util/types');
     assert.ok(types, 'node:util/types is not exported');
+    assert.ok(types.isTypedArray);
+    assert.ok(types.default.isTypedArray);
   },
 };