Skip to content

Commit e4011b1

Browse files
chore: inherit vitest settings from the root (#4800)
1 parent 1d575bc commit e4011b1

File tree

33 files changed

+267
-272
lines changed

33 files changed

+267
-272
lines changed

CONTRIBUTING.md

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -205,17 +205,21 @@ As a reviewer, it's important to be thoughtful about the proposed changes and co
205205

206206
Every PR should include tests for the functionality that's being added. Most changes will be to [Wrangler](packages/wrangler/src/__tests__) (using Jest), [Miniflare](packages/miniflare/test) (using Ava), or [C3](packages/create-cloudflare/src/__tests__) (using Vitest), and should include unit tests within the testing harness of those packages.
207207

208-
If your PR includes functionality that's difficult to unit test, you can add a fixture test by creating a new package in the `fixtures/` folder. This allows for adding a test that requires a specific filesystem or worker setup (for instance, `fixtures/no-bundle-import` tests the interaction of Wrangler with a specific set of JS, WASM, text, and binary modules on the filesystem). When adding a fixture test, include a `vitest.config.ts` file within the new package, which will ensure it's run as part of the `workers-sdk` CI. A good default example is the following:
208+
If your PR includes functionality that's difficult to unit test, you can add a fixture test by creating a new package in the `fixtures/` folder. This allows for adding a test that requires a specific filesystem or worker setup (for instance, `fixtures/no-bundle-import` tests the interaction of Wrangler with a specific set of JS, WASM, text, and binary modules on the filesystem). When adding a fixture test, include a `vitest.config.ts` file within the new package, which will ensure it's run as part of the `workers-sdk` CI. You should merge your own configuration with the default config from the root of the repo.
209+
210+
A good default example is the following:
209211

210212
```ts
211-
import { defineConfig } from "vitest/config";
212-
213-
export default defineConfig({
214-
test: {
215-
testTimeout: 5_000,
216-
hookTimeout: 5_000,
217-
teardownTimeout: 5_000,
218-
},
213+
import { defineProject, mergeConfig } from "vitest/config";
214+
import configShared from "../../vitest.shared";
215+
216+
export default mergeConfig(
217+
configShared,
218+
defineProject({
219+
test: {
220+
// config overrides
221+
}
222+
})
219223
});
220224
```
221225

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 15_000,
6-
hookTimeout: 15_000,
7-
teardownTimeout: 15_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);

fixtures/ai-app/vitest.config.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 25_000,
6-
hookTimeout: 25_000,
7-
teardownTimeout: 25_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 25_000,
6-
hookTimeout: 25_000,
7-
teardownTimeout: 25_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 30_000,
6-
hookTimeout: 30_000,
7-
teardownTimeout: 30_000,
8-
useAtomics: true,
9-
// `node-pty` doesn't work inside worker threads
10-
threads: false,
11-
},
12-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {
8+
// `node-pty` doesn't work inside worker threads
9+
threads: false,
10+
},
11+
})
12+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 20_000,
6-
hookTimeout: 20_000,
7-
teardownTimeout: 20_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { defineConfig } from "vitest/config";
1+
import { defineProject, mergeConfig } from "vitest/config";
2+
import configShared from "../../vitest.shared";
23

3-
export default defineConfig({
4-
test: {
5-
testTimeout: 10_000,
6-
hookTimeout: 10_000,
7-
teardownTimeout: 10_000,
8-
useAtomics: true,
9-
},
10-
});
4+
export default mergeConfig(
5+
configShared,
6+
defineProject({
7+
test: {},
8+
})
9+
);

0 commit comments

Comments
 (0)