Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete command is missing support for force deletion parameter resulting in error #1

Open
shouah opened this issue Feb 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@shouah
Copy link

shouah commented Feb 29, 2024

The 'delete-job' and 'delete-job-schedule' and 'delete-call' and 'delete-call-schedule' commands are all missing support for the optional '--force' or '-f' option causing execution error due to incompatible syntax and resulting in unexpected duplicated setup since the delete command with the optional option is not taking effect:

USAGE:
delete-job JOB_NAME [--force]
delete-job-schedule JOB_NAME SCHEDULE_GUID [--force]
delete-call CALL_NAME [--force]
delete-call-schedule CALL_NAME SCHEDULE_GUID [--force]

OPTIONS:
--force, -f Force deletion without confirmation

@wayneeseguin wayneeseguin added the enhancement New feature or request label Jun 11, 2024
@norman-abramovitz
Copy link
Contributor

We are currently deciding if we are going to implement the prompt if the force is not set or just treat the force flag as a noop argument since the command's default behavior is to delete.

@norman-abramovitz
Copy link
Contributor

It was decided not to add the prompt at this time to avoid making behavioral changes, so we can do a small point release for this enhancement.

@norman-abramovitz
Copy link
Contributor

norman-abramovitz commented Jun 14, 2024

PR #2 Will be fixing this issue. Also added a --prompt flag that actually performs the prompting. This does not change the current behavior since an explicit action is required to get the confirmation to function. The --prompt flag will not be externally documented through the plugin at this time. Once the PR gets through the pipeline, this issue will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants