Skip to content

chore: Bump log-cache plugin from v6.0.1 to v6.2.1 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Jan 15, 2025

Thank you for contributing to the CF CLI Plugin Repository!

This repo contains both the plugin repo server and the metadata for CLI
community plugins.
Some of the requirements for PRs will apply to only one of these parts.

We're not allowed to accept any PRs without a signed CLA, no matter how small.
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.

Submitting Plugins

If you haven't yet, please review our contributing guidelines:
https://github.com/cloudfoundry/cli-plugin-repo#submitting-plugins

In particular ensure the following requirements are being met:

  • The plugin's name field in repo-index.yml matches the Name field in the plugin's plugin.PluginMetadata section
  • The plugin's url field in repo-index.yml contains the same version from the version field

Submitting PRs to CLIPR (the CLI Plugin Repo server)

All new code requires tests to protect against regressions.

Description of the Change

Bump log-cache plugin to v6.2.1.

Why Is This PR Valuable?

Bumps log-cache plugin to v6.2.1.

Applicable Issues

None

How Urgent Is The Change?

Slightly less than urgent.

Other Relevant Parties

None.

Copy link

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is important change as the CAPI v2 will be disabled by default in cf-deployment by the end of the month.

Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version and source exist on log cache cf plugin repo

Unrelated, amused to see that log cache cf plugin repo produces a win 32 artifact

@moleske moleske merged commit 56f7aa3 into cloudfoundry:main Jan 19, 2025
2 checks passed
@chombium
Copy link

Unrelated, amused to see that log cache cf plugin repo produces a win 32 artifact

@moleske I find that interesting too... Do you think that we should remove that? Do we have some usage or download stats somewhere for cf cli plugins maybe?

@moleske
Copy link
Member

moleske commented Jan 20, 2025

https://plugins.cloudfoundry.org/#log-cache does not list windows 32 as a download, only windows 64. So it is unlikely anyone is downloading it from plugins.cloudfoundry.org

edit - maybe if you're installing from the cli itself it pulls win 32 if you're using the win 32 version of the cli. I don't really know why there's a win 32 version of the cli. Most likely no one thinking about and letting the release automation just go

@ctlong ctlong deleted the bump/log-cache/6.2.1 branch January 21, 2025 17:48
@ctlong
Copy link
Member Author

ctlong commented Jan 21, 2025

I recently added an darwin / arm release for myself, which I don't think the plugin repos supports yet... anyway, happy to go remove the win32 release since I'm not very familiar with that release flow 😁

@ctlong
Copy link
Member Author

ctlong commented Jan 21, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants