Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC0034] App Manifests v2 #1051

Open
1 task
beyhan opened this issue Jan 22, 2025 · 3 comments
Open
1 task

[RFC0034] App Manifests v2 #1051

beyhan opened this issue Jan 22, 2025 · 3 comments
Labels
rfc CFF community RFC

Comments

@beyhan
Copy link
Member

beyhan commented Jan 22, 2025

This is a tracking issue for the implementation of https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0034-v2-app-manifests.md

Tasks

Preview Give feedback
@norman-abramovitz
Copy link

norman-abramovitz commented Jan 23, 2025

There was convention that got lost over time. The use of underscores was for names given that what is most programming languages used. Dashes was used to separate combined keys like combining GUIDS. The colon was to separate major components like it does in the /etc/passwd file. If you are considering moving towards only underscores, you should consider a convention that covers all known usages and provide some form of escaping or mapping functions when an outside process needs a format.

If you want additional information, you can contact me through slack or github.

@norman-abramovitz
Copy link

norman-abramovitz commented Jan 23, 2025

When breaking out components like services into their own top level item, please do not lose the knowledge how those components relate back to the other other components. A person should be able see or draw a graph of the relationships. What I saw in the example cases the relationships are lost.

If you want additional information, you can contact me through slack or github.

@norman-abramovitz
Copy link

norman-abramovitz commented Jan 23, 2025

I hope we do not rename the manifest or have a better name than "space manifest." I feel it needs to make sense to the role that the api/cli interface is was designed for. Unless you are planning to put all pushed processes into a single space manifest, the use of the term "space manifest" would be very confusing. It is possible to design an interface where it makes sense but that might be V4 interface.

If you want additional information, you can contact me through slack or github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc CFF community RFC
Projects
Status: Inbox
Development

No branches or pull requests

2 participants