From 5e896642d785bc7e46c780f892c7d8aa6a367c56 Mon Sep 17 00:00:00 2001
From: Adrian Hoelzl <adrian.hoelzl@sap.com>
Date: Fri, 15 Mar 2024 11:45:37 +0100
Subject: [PATCH] Rework: remove setType call from
 assertThatIllegalArgumentException lambda in ScimUserTests.testPhoneNumber

---
 .../cloudfoundry/identity/uaa/scim/ScimUserTests.java    | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/model/src/test/java/org/cloudfoundry/identity/uaa/scim/ScimUserTests.java b/model/src/test/java/org/cloudfoundry/identity/uaa/scim/ScimUserTests.java
index 3f179f9204b..c56ae8e49d0 100644
--- a/model/src/test/java/org/cloudfoundry/identity/uaa/scim/ScimUserTests.java
+++ b/model/src/test/java/org/cloudfoundry/identity/uaa/scim/ScimUserTests.java
@@ -452,10 +452,11 @@ public void testPhoneNumber() {
         ScimUser user = new ScimUser();
         user.setPhoneNumbers(Collections.singletonList(p1));
 
-        assertThatIllegalArgumentException().isThrownBy(() -> {
-            p1.setType(null);
-            user.addPhoneNumber(p1.getValue());
-        });
+        // should reject adding duplicate phone number if the existing has a type set to null
+        p1.setType(null);
+        assertThatIllegalArgumentException()
+                .isThrownBy(() -> user.addPhoneNumber(p1.getValue()))
+                .withMessageStartingWith("Already contains phoneNumber");
     }
 
     @Test