Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test bug (SamlLoginIT) #2957

Conversation

peterhaochen47
Copy link
Member

  • this test creates a real SAML provider (pointing to a running saml server: http://simplesamlphp.uaa-acceptance.cf-app.com/saml2/idp/metadata.php) and also a dummy SAML provider (pointing to a randomly generated saml idp metadata). Before this commit, the test is mistakenly performing SAML flow via the dummy provider only (which somehow works currently on this branch but is probably not what this test intends to do). This is because the two providers have identical login link texts (which are shown on the UAA login page) and the click action ends up clicking the wrong provider link text.
  • this commit fixes the issue by differentiating the two providers by different login link text, so that the test is now performing SAML flow via the real IDP.

- this test creates a real SAML provider (pointing to a running saml
  server:
  http://simplesamlphp.uaa-acceptance.cf-app.com/saml2/idp/metadata.php)
  and also a dummy SAML provider (pointing to a randomly generated saml idp
  metadata). Before this commit, the test is mistakenly performing
  SAML flow via the dummy provider only (which somehow works currently
  on this branch but is probably not what this test intends to do). This
  is because the two providers have identical login link texts (which
  are shown on the UAA login page) and the click action ends up clicking
  the wrong provider link text.
- this commit fixes the issue by differentiating the two providers
  by different login link text, so that the test is now performing
  SAML flow via the real IDP.
@peterhaochen47 peterhaochen47 requested a review from a team July 16, 2024 04:41
@peterhaochen47 peterhaochen47 merged commit 828386b into develop Jul 16, 2024
22 checks passed
@peterhaochen47 peterhaochen47 deleted the pr/fix-saml-login-it-testSimpleSamlPhpLoginInTestZone1Works branch July 16, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants