Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Add stylelint-use-logical-spec #215

Closed
wants to merge 1 commit into from
Closed

[DRAFT] Add stylelint-use-logical-spec #215

wants to merge 1 commit into from

Conversation

spaceninja
Copy link
Member

This PR adds the stylelint-use-logical-spec plugin,
which adds the following rule:

  • liberty/use-logical-spec: Always require logical properties and values,
    except for float, clear, and border-radius.

tylersticka
tylersticka reviewed Nov 17, 2021
View reviewed changes
Copy link
Member

@tylersticka tylersticka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought @Paul-Hebert and @gerardo-rodriguez had only approved this approach if it were limited to our new patterns and wanted to give it more thought if it applied to all of our projects moving forward, but I may be misunderstanding their comments on the relevant Slack thread.

(I feel a little strange adding this to our shared config before we've had a chance to thoroughly test these props in a project, TBH. But I can't decide if that's warranted or not!)

@gerardo-rodriguez
Copy link
Member

I thought @Paul-Hebert and @gerardo-rodriguez had only approved this approach if it were limited to our new patterns and wanted to give it more thought if it applied to all of our projects moving forward, but I may be misunderstanding their comments on the relevant Slack thread.

@tylersticka Correct, this is what I meant.

@spaceninja
Copy link
Member Author

Sorry, jumped the gun! I'll set this back to Draft and leave it here if we decide it's valid.

@spaceninja spaceninja marked this pull request as draft November 17, 2021 22:56
@spaceninja spaceninja changed the title Add stylelint-use-logical-spec [DRAFT] Add stylelint-use-logical-spec Nov 18, 2021
@spaceninja spaceninja closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersticka tylersticka tylersticka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stylelint-use-logical-spec
3 participants
@spaceninja @gerardo-rodriguez @tylersticka