Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the contribution workflow #94

Open
wildintellect opened this issue Nov 11, 2023 · 0 comments
Open

Clarify the contribution workflow #94

wildintellect opened this issue Nov 11, 2023 · 0 comments

Comments

@wildintellect
Copy link
Contributor

#74 highlights that previews only build for PRs within the main repository and not from outside forks.

Once the pull request is opened, and the GitHub `preview.yml` workflow runs ("Deploy PR previews"), you should have a preview available for review at `https://guide.cloudnativegeo.org/pr-preview/pr-<YOUR-PR-NUMBER-HERE>`. A bot will comment on your PR when the PR preview is ready.

Due to this we need to update the docs on how contributions work.

  1. Make a PR to staging, the content will be checked.
  2. Maintainer will merge then open a PR to main. At this point the actual build preview will run and we can all verify it looks as expected.
  3. Maintainers merge to main

^^
This isn't an ideal workflow, we are open to alternatives as mentioned in the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant