Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README Template Update #358

Merged
merged 10 commits into from
Oct 16, 2023
Merged

README Template Update #358

merged 10 commits into from
Oct 16, 2023

Conversation

milldr
Copy link
Member

@milldr milldr commented Oct 13, 2023 •
edited
Loading

what

  • Replaced Contributors with contrib.rocks contributors block
  • Removed social links and discourse
  • Clean up unnecessary content

why

  • Automatically keep contributors up-to-date
  • Our contributors are gravely out of date
  • It helps to showcase the popularity of a repo
  • Keeping README up-to-date with latest conventions/recommendations

references

@milldr milldr requested review from a team as code owners October 13, 2023 21:02
@milldr
Copy link
Member Author

milldr commented Oct 13, 2023

CleanShot 2023-10-13 at 14 06 00

@milldr milldr added the no-release Do not create a new release (wait for additional code changes) label Oct 16, 2023
@milldr
Copy link
Member Author

milldr commented Oct 16, 2023

lint GHA will fail until master is updated. Will need to create a follow up PR to update README and create release

osterman
osterman reviewed Oct 16, 2023
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
milldr and others added 2 commits October 16, 2023 12:36
@milldr @osterman
Apply suggestions from code review
bfe79fb 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>
@milldr
Added ✨
4b2857a
osterman
osterman reviewed Oct 16, 2023
View reviewed changes
templates/README.md.gotmpl Outdated
@@ -420,24 +420,15 @@ Check out [our other projects][github], [follow us on twitter][twitter], [apply


{{ if has (datasource "config") "contributors" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm... I wonder if this still makes sense having the conditional?

@milldr milldr changed the title Use contrib.rocks for Contributors README Template Update Oct 16, 2023
@milldr milldr merged commit d7343ad into master Oct 16, 2023
12 of 13 checks passed
@milldr milldr deleted the readme-contributors branch October 16, 2023 21:39
This was referenced Oct 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

Assignees

@milldr milldr

Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milldr @osterman @cloudpossebot