Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Let's update this module to follow best security practices #195

Open
Gowiem opened this issue Jan 20, 2025 · 2 comments
Open

Proposal: Let's update this module to follow best security practices #195

Gowiem opened this issue Jan 20, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request major Breaking changes (or first stable release)

Comments

@Gowiem
Copy link
Member

Gowiem commented Jan 20, 2025

Describe the Feature

I was writing a blog post about how open-source modules are great because we get the best security practices out of the box. And I was looking at this module to provide a good example of that... and yet, I don't think it does a great job in the "security first" category. Examples below in expected behavior.

Expected Behavior

What I'd expect this module to do by default:

  1. HTTP (port 80) enabled, but redirects to HTTPS (port 443) by default
  2. HTTPS enabled by default and certificate_arn required (null allowed in the case that the user wants to configure HTTP only)

Use Case

I believe Cloud Posse modules should be built to be secure by default, and should be configurable for the POC use-cases (e.g. using HTTP instead of HTTPS).

Describe Ideal Solution

We implement secure by default.

Alternatives Considered

No response

Additional Context

No response

@RoseSecurity
Copy link

I agree with the proposed defaults in this proposal. To quote Cloud Posse Terraform Best Practices:

"Modules should be as turnkey as possible. The default value should ensure the most secure configuration (E.g. with encryption enabled)."

I'd also double down and say that the module should offer better support for gRPC and HTTP/2 applications and secure configurations for those protocols as well.

@Gowiem
Copy link
Member Author

Gowiem commented Jan 21, 2025

Discussed internally to @cloudposse contributors and we've decided this is worth doing. I'll note this down as a go and circle back around to implement when I have time 👍

@Gowiem Gowiem self-assigned this Jan 21, 2025
@Gowiem Gowiem added enhancement New feature or request major Breaking changes (or first stable release) labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major Breaking changes (or first stable release)
Projects
None yet
Development

No branches or pull requests

2 participants