Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some conflicts in the code and the results in the paper #392

Open
ricupa opened this issue Apr 9, 2024 · 0 comments
Open

some conflicts in the code and the results in the paper #392

ricupa opened this issue Apr 9, 2024 · 0 comments

Comments

@ricupa
Copy link

ricupa commented Apr 9, 2024

In the code you have shared, i.e., the unet_mobilenetv2.ipynb (or .py), it doesn't seem like the entire code reproduces the results in the paper. The paper gives binary segmentation results (cloud/no cloud, valid/invalid/ etc.), but your code is for multi-class segmentation. Also, the metrics classes are not for the results you have presented.
So, am I looking at the wrong code? Have I found the wrong code, and is the correct one somewhere else in the repo?

I have one more concern: in the Unet model that you have initialized, you have not applied any activation at the output, and during the validation, while calculating the metrics, you take the arg max (without the softmax across the classes; see line 359 in the py file), in such the case the metrics calculation can be incorrect. Please let me know if I am wrong here or if I am missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant