Skip to content
This repository has been archived by the owner on Dec 21, 2024. It is now read-only.

no index.js #75

Open
sylvainlap opened this issue Jan 26, 2016 · 9 comments
Open

no index.js #75

sylvainlap opened this issue Jan 26, 2016 · 9 comments
Labels

Comments

@sylvainlap
Copy link

Hi,

After a git clone & npm install, I try to run the devServer thanks to npm start.
Here is the log:

sylvainlap@CanHardXI:~/DEV/WORKSPACE/universal-react-boilerplate$ npm start

> universal-react-boilerplate@3.0.0 start /home/sylvainlap/DEV/WORKSPACE/universal-react-boilerplate
> cross-env NODE_PATH=source babel-node devServer.js

Listening at http://0.0.0.0:3000
webpack built 151bfb56c4b20df6835c in 1366ms

However, when I try to reach http://localhost:3000/, I got a blank page. Moreover, I don't have any index.js in the static folder. What am I doing wrong ?

Thanks.

@nkbt
Copy link
Contributor

nkbt commented Jan 26, 2016

May it be related to #73 ?

@ericelliott
Copy link
Contributor

Verified. Something broke the Redux store hookups, and this reveals a big weakness in our tests. We need to test the actual data being rendered, rather than simply checking that the routes don't have errors.

I'm currently occupied with encapsulating all these hookups in react-easy-universal. When that is finished, I'll replace the code here.

In the meantime, I think it would be useful to figure out what's going on here. It may even help me with the work I'm doing. Would anybody like to investigate and try a PR?

@nkbt
Copy link
Contributor

nkbt commented Jan 26, 2016

I can do e2e tests. I have smoke-tests in place for all my libs.

@nkbt
Copy link
Contributor

nkbt commented Jan 26, 2016

Created #76

@ericelliott
Copy link
Contributor

I don't have any index.js in the static folder.

You shouldn't. index.js gets served from /build. You should not see a 404 error for /static/index.js. Do you? If so, try:

npm run build

@ericelliott
Copy link
Contributor

The missing index file should be fixed by #71. Basically, just run npm run build.

@robbestad
Copy link
Contributor

Can confirm. npm run build fixes it. However, I ran into a couple of other issues. I get undefined in location when accessing http://0.0.0.0:8080. Accessing the test-data route manually works just fine. Additionally, I can't really get any effect out of the hot-reload, because if I for instance edit the test-data component manually, nothing happens. If I refresh, the changes are visible for a second, before being replaced by the static content.

@mgreer
Copy link

mgreer commented Mar 15, 2016

Agreed with @svenanders , having exactly the same issue after running build then start. Backend is hot compiling, but front end does not seem to be listening and even a hard refresh shows new code for an instant, before reverting to old code from manual build.

@ericelliott
Copy link
Contributor

Open to PRs! Would one of you like to tackle these issues?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants