Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get funding round factory information from the subgraph instead of from contract #679

Open
yuetloo opened this issue Jun 9, 2023 · 2 comments
Assignees

Comments

@yuetloo
Copy link
Collaborator

yuetloo commented Jun 9, 2023

Currently, the code makes 5 contract calls to get all the information instead of just 1 subgraph call to get all information.

@yuetloo yuetloo self-assigned this Jun 9, 2023
@cold-briu
Copy link

Hi there!
I'm having a similar issue, but I've couldn't find the issue.
Can you share how you found that its get funding round factory information hopefully we can fix it togheter

@yuetloo
Copy link
Collaborator Author

yuetloo commented Mar 8, 2024

@cold-briu , this issue was to track refactoring of this function:
https://github.com/clrfund/monorepo/blob/develop/vue-app/src/api/round.ts#L131

But, a lot have changed in the MACI v1 integration branch, so, this issue will be addressed as part of that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants