You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gen/foo/v1/foo_temporal.pb.go:1181:10: result.XBar undefined (type FooInput has no field or method XBar)
gen/foo/v1/foo_temporal.pb.go:1181:18: undefined: FooInput_Bar
gen/foo/v1/foo_temporal.pb.go:1181:16: cannot use cmd.String("bar") (value of type string) as *string value in assignment
Is there any technical reason/limitation or design philosophy not to support optional feature ? And if not would you think it would be possible to add support for it ?
Note that the issue seems to be only related to the generated CLI as buf with option cli-enabled=false do not generate any invalid code.
Thanks
The text was updated successfully, but these errors were encountered:
Hello,
I'm currently converting some services to Temporal workers. These services already defines Protobuf files and sometimes rely on
optional
fields.I'm getting warning message when using those proto messages. Here is a simple example :
The generated code do not work either as the generated
UnmarshalCliFlagsToFooInput
will consider the field to beoneof
(here https://github.com/cludden/protoc-gen-go-temporal/blob/main/internal/plugin/cli.go#L944) and use unresolved referencesXBar
and unresolved typeFooInput_Bar
:Resulting in the following error :
If using
proto2
there's not warning, the field is not considered asoneof
(here https://github.com/cludden/protoc-gen-go-temporal/blob/main/internal/plugin/cli.go#L947) but the generated code do not work either ascmd.String
is returning astring
where the field is actually a*string
.Is there any technical reason/limitation or design philosophy not to support
optional
feature ? And if not would you think it would be possible to add support for it ?Note that the issue seems to be only related to the generated CLI as buf with option
cli-enabled=false
do not generate any invalid code.Thanks
The text was updated successfully, but these errors were encountered: