Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Validator for Weekly Data #1117

Open
qx-teo opened this issue Jul 13, 2021 · 2 comments
Open

Adapt Validator for Weekly Data #1117

qx-teo opened this issue Jul 13, 2021 · 2 comments

Comments

@qx-teo
Copy link
Contributor

qx-teo commented Jul 13, 2021

Summary
Validator currently only works on daily data, which means that it cannot be organically ran on sources like nchs-mortality.

Possible Solutions

  • Releasing a version of the validator that only does checks unaffected by the weekly nature of the data (e.g. checking for missing date files, missing geo-type signal-type combinations) - will still need to tweak checks (e.g. making check_missing_dates only check for the first date of an epiweek)
  • Adapting parameters to consider the last N data-points (a.k.a weeks) rather than the last N days (Issues with this: Using data from 14 weeks ago as a reference may not work as well in determining things like outliers or trends)
@qx-teo qx-teo self-assigned this Aug 20, 2021
@krivard krivard added the Priority-P1 Hope to do; lab will survive without it label Aug 24, 2021
@qx-teo
Copy link
Contributor Author

qx-teo commented May 27, 2022

@nmdefries nmdefries removed the Priority-P1 Hope to do; lab will survive without it label Jul 22, 2024
@nmdefries
Copy link
Contributor

Address #2023 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants