Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor weighted aggregation for hhs as a method in the geomapper #2038

Open
minhkhul opened this issue Aug 27, 2024 · 0 comments
Open

Refactor weighted aggregation for hhs as a method in the geomapper #2038

minhkhul opened this issue Aug 27, 2024 · 0 comments

Comments

@minhkhul
Copy link
Contributor

minhkhul commented Aug 27, 2024 •
edited
Loading

This will definitely work, though it would be better if this were implemented as a method in the geomapper itself, for 2 reasons: reuse, and speed. aggregate_by_weighted_sum has to create the weights at every single time_value, which means it's definitely slower.

Originally posted by @dsweber2 in #2036 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minhkhul