Fixed a rendering bug in the feedback report

Author: sei-bstein

projects/gameboard-ui/src/app/admin/components/feedback-editor/feedback-editor.component.ts

@@ -1,11 +1,7 @@
 import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
 import { BehaviorSubject, debounceTime, tap } from 'rxjs';
 import { FeedbackTemplate } from '@/api/feedback-models';
-import { YamlService } from '@/services/yaml.service';
 import { UnsubscriberService } from '@/services/unsubscriber.service';
-import { isObject } from '@/../tools/functions';
-import { YAMLParseError } from 'yaml';
-import { FeedbackService } from '@/api/feedback.service';
 import { ModalConfirmService } from '@/services/modal-confirm.service';
 
 @Component({
@@ -25,10 +21,8 @@ export class FeedbackEditorComponent implements OnInit {
   private templateChangeSubject$ = new BehaviorSubject<FeedbackTemplate | null>(null);
 
   public constructor(
-    private feedbackService: FeedbackService,
     private modalService: ModalConfirmService,
-    private unsub: UnsubscriberService,
-    private yamlService: YamlService) {
+    private unsub: UnsubscriberService) {
     this.unsub.add(
       this.templateChangeSubject$
         .pipe(

projects/gameboard-ui/src/app/api/game.service.ts

@@ -174,7 +174,6 @@ export class GameService {
     try {
       if (game.feedbackConfig) {
         game.feedbackTemplate = this.yamlService.parse<FeedbackTemplate>(game.feedbackConfig);
-        console.log("loaded game template", game.feedbackTemplate);
       }
     }
     catch {

projects/gameboard-ui/src/app/feedback/components/feedback-submission-form/feedback-submission-form.component.html

@@ -7,7 +7,7 @@
             <small><span class="font-weight-bold align-middle">{{template?.helpText}}</span></small>
         </div>
 
-        <ng-container *ngIf="!submission.whenFinalized && !isAdminView; else finalized">
+        <ng-container *ngIf="!submission.whenFinalized; else finalized">
             <div *ngFor="let q of submission.responses; let i = index" class="mb-4">
                 <label for="{{q.id}}">
                     <div class="d-flex">
@@ -118,7 +118,7 @@
 </div>
 
 <ng-template #finalized>
-    <alert type="success" *ngIf="!isAdminView">
+    <alert type="success">
         Thanks for submitting your feedback! We saved it on
         <strong>{{ submission.whenFinalized | friendlyDateAndTime }}</strong>.
     </alert>

projects/gameboard-ui/src/app/feedback/components/feedback-submission-form/feedback-submission-form.component.ts

@@ -31,7 +31,6 @@ import { SpinnerComponent } from '@/standalone/core/components/spinner/spinner.c
 export class FeedbackSubmissionFormComponent implements AfterViewInit, OnInit, OnDestroy {
   @Input() feedbackEntity?: FeedbackSubmissionAttachedEntity;
   @Input() templateId?: string;
-  @Input() isAdminView = false;
   @Input() isPreview = false;
   @ViewChild(NgForm) form!: FormGroup;
 
@@ -74,10 +73,6 @@ export class FeedbackSubmissionFormComponent implements AfterViewInit, OnInit, O
   }
 
   async submit(isAutoSave = false) {
-    if (this.isAdminView) {
-      return;
-    }
-
     if (!this.feedbackEntity) {
       throw new Error("Feedback entity is required");
     }

projects/gameboard-ui/src/app/reports/components/reports/feedback-report/feedback-report.component.ts

@@ -77,6 +77,7 @@ export class FeedbackReportComponent extends ReportComponentBase<FeedbackReportP
   };
 
   protected handleRecordClick(record: FeedbackReportRecord) {
+    console.log("opening record", record);
     this.modalService.openComponent({
       content: PlayerFeedbackResponsesModalComponent,
       context: {

projects/gameboard-ui/src/app/reports/components/reports/feedback-report/player-feedback-responses-modal/player-feedback-responses-modal.component.html

@@ -1,4 +1,12 @@
 <app-modal-content *ngIf="record" title="Feedback" [subtitle]="record.user.name" [hideCancel]="true">
-    <app-feedback-submission-form [templateId]="templateId" [isAdminView]="true"
-        [feedbackEntity]="record.entity"></app-feedback-submission-form>
+    <ol>
+        <li *ngFor="let response of record.responses; index as i" class="my-4">
+            <strong>{{ i + 1 }}. {{ response.prompt }}</strong>
+            <div class="my-2" *ngIf="response.answer">{{ response.answer }}</div>
+        </li>
+    </ol>
 </app-modal-content>
+
+<ng-template #noResponse>
+    <em>(no response)</em>
+</ng-template>